Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated apis on superset, get_or_create_table, sqllab_viz #24375

Merged
merged 13 commits into from
Jun 14, 2023

Conversation

dpgaspar
Copy link
Member

SUMMARY

Removes old deprecated APIs:

  • /superset/get_or_create_table/...
  • /superset/sqllab_viz/...

Effort on removing deprecated APIs from /superset: #24332

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dpgaspar dpgaspar changed the title Chore/remove deprecated apis 9 chore: remove deprecated apis on superset, get_or_create_table, sqllab_viz Jun 13, 2023
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #24375 (6ce3c6f) into master (69984e6) will increase coverage by 1.81%.
The diff coverage is 100.00%.

❗ Current head 6ce3c6f differs from pull request most recent head e32e0eb. Consider uploading reports for the commit e32e0eb to get more accurate results

@@            Coverage Diff             @@
##           master   #24375      +/-   ##
==========================================
+ Coverage   67.13%   68.95%   +1.81%     
==========================================
  Files        1903     1903              
  Lines       74123    74067      -56     
  Branches     8110     8110              
==========================================
+ Hits        49765    51074    +1309     
+ Misses      22246    20881    -1365     
  Partials     2112     2112              
Flag Coverage Δ
hive 53.86% <100.00%> (?)
mysql 79.26% <100.00%> (-0.05%) ⬇️
postgres 79.33% <100.00%> (-0.05%) ⬇️
presto 53.78% <100.00%> (?)
python 83.31% <100.00%> (+3.79%) ⬆️
sqlite 77.83% <100.00%> (-0.05%) ⬇️
unit 54.56% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/security/manager.py 93.83% <ø> (ø)
superset/views/core.py 72.35% <100.00%> (-1.81%) ⬇️

... and 100 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dpgaspar dpgaspar changed the title chore: remove deprecated apis on superset, get_or_create_table, sqllab_viz chore: remove deprecated apis on superset, get_or_create_table, sqllab_viz Jun 13, 2023
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpgaspar dpgaspar merged commit c69634d into apache:master Jun 14, 2023
29 checks passed
@dpgaspar dpgaspar deleted the chore/remove-deprecated-apis-9 branch June 14, 2023 07:48
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants