-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: deprecate FLASK_ENV and improve conf.ENVIRONMENT_TAG_CONFIG #24404
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24404 +/- ##
=======================================
Coverage 68.93% 68.93%
=======================================
Files 1904 1904
Lines 73880 73886 +6
Branches 8119 8119
=======================================
+ Hits 50929 50935 +6
Misses 20840 20840
Partials 2111 2111
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Flask is deprecating FLASK_ENV, leading to this msg in the interpreter:
SUMMARY
Moving away from using
FLASK_ENV
and creating aSUPERSET_ENV
instead. Cleaning up the code around the configurationENVIRONMENT_TAG_CONFIG
too that relied on that.Adding a note on
UPDATING.md
at it may affect some environments, mostly should just affect whether and how that warning tag in the navbar shows up.TESTED
export SUPERSET_ENV=development
leads toDevelopment
tag showing in navbarexport SUPERSET_ENV=production
leads to no tag showing in navbarunset SUPERSET_ENV
leads toflask-debug
tag in navbarexport SUPERSET_ENV=giberrish
leads toflask-debug
tag in navbarBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF