-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(logs): increase json field for logs table #24911
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24911 +/- ##
=======================================
Coverage 69.00% 69.00%
=======================================
Files 1906 1906
Lines 74134 74134
Branches 8208 8208
=======================================
Hits 51153 51153
Misses 20858 20858
Partials 2123 2123
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
5f0e538
to
fd3d4e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@cnabro thanks for the change. Would you mind also authoring a follow up PR which adds a line record to Additionally I saw you checked the,
checkbox, but I couldn't see any stats reported. Would you mind updating the PR description to include the necessary statistics. |
@john-bodley Thank you. I'd added some notices in this PR (#24923). |
(cherry picked from commit eb7c145)
@cnabro looking over your PR I noticed that you didn't actually update the SQLAlchemy model definition. Would you mind authoring a follow up PR to include the model change? |
@john-bodley Ok. I'll give you another PR 😀 |
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION