chore: Deprecates the KV_STORE feature flag #26450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-s-molina
added
hold!
michael-s-molina
force-pushed
the
deprecate-kv-store-ff
branch
from
e870d15
to
2895bae
Compare
9 tasks
michael-s-molina
force-pushed
the
deprecate-kv-store-ff
branch
from
2895bae
to
d0f2c4e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #26450 +/- ##
=======================================
Coverage 69.16% 69.16%
=======================================
Files 1948 1948
Lines 76054 76056 +2
Branches 8493 8493
=======================================
+ Hits 52601 52603 +2
Misses 21273 21273
Partials 2180 2180
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
john-bodley
approved these changes
Jan 10, 2024
john-bodley
added
review:checkpoint
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
As part of the 4.0 approved initiatives, this PR deprecates the
KV_STOREfeature flag and its related assets such as the API endpoint andkeyvaluetable. The main dependency of this feature is theSHARE_QUERIES_VIA_KV_STOREfeature flag which allows sharing SQL Lab queries without the necessity of saving the query. Our intention is to use the permalink feature to implement this use case before 5.0 and that's why we are deprecating the feature flag now.TESTING INSTRUCTIONS
CI.
ADDITIONAL INFORMATION