chore: clean up console upon firing up the CLI #28134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there's some irrelevant DEBUG-level type logging happening when using the CLI, here I'm doing the following things: - setting the default logging level to INFO, which is the normal/sane default usually used in software - downgrading unimportant messages in the console from INFO to DEBUG - adding a dash of color on the title (bolded-white) and config loading INFO (cyan) - turning off load limiter when not in a `production` environment (added a note to `UPDATING.md` for that)
qleroy
pushed a commit
to qleroy/superset
that referenced
this pull request
Apr 28, 2024
jzhao62
pushed a commit
to jzhao62/superset
that referenced
this pull request
May 16, 2024
|
Hi, I have a similar PR which aims to further clean up default logging: #27777 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently there's some irrelevant DEBUG-level type logging happening when using the CLI, here I'm doing the following things:
RATELIMIT_ENABLEDtoFalsewhen not in aproductionenvironment (added a note toUPDATING.mdfor that)Screenshots