Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[setup] Dropping 3.4 and adding 3.6 #4835

Merged
merged 3 commits into from
Apr 18, 2018

Conversation

john-bodley
Copy link
Member

@john-bodley john-bodley commented Apr 17, 2018

Since 0.21.0 Pandas has dropped support for Python 3.4 which is now causing problems with Travis CI. I speculate the issue is only now surfacing with the release of pip version 10.0 per this thread.

It seems other applications are dropping support for Python 3.4 and I was wondering whether we should do the same (and adding Python 3.6 as a replacement) as opposed to having to write specific logic to handle different Pandas versions.

This PR also updated the Travis CI matrix to include both Python 2.7 and 3.6 which ensures that the nosetests run in the Python version specified by Travis, and that both flake8 and pylint run for all Python versions (previously these ran only for Python 2.7).

to: @fabianmenges @mistercrunch
cc: @timifasubaa

@john-bodley john-bodley force-pushed the john-bodley-deprecate-py34 branch 8 times, most recently from b592b9c to 9589f77 Compare April 17, 2018 06:09
@codecov-io
Copy link

codecov-io commented Apr 17, 2018

Codecov Report

Merging #4835 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4835   +/-   ##
=======================================
  Coverage   72.36%   72.36%           
=======================================
  Files         208      208           
  Lines       15662    15662           
  Branches     1227     1227           
=======================================
  Hits        11334    11334           
  Misses       4325     4325           
  Partials        3        3
Impacted Files Coverage Δ
superset/cli.py 44.06% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2900ca3...f74ad17. Read the comment docs.

@timifasubaa
Copy link
Contributor

timifasubaa commented Apr 17, 2018

In support of knocking out python 3.4. One of our dependencies (tornadoweb) does not support python 3.4.

LGTM

@mistercrunch
Copy link
Member

LGTM

@john-bodley john-bodley merged commit 44c2d5b into apache:master Apr 18, 2018
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
* [setup] Dropping 3.4 and 3.6

* Update tox.ini

* Update .travis.yml
timifasubaa pushed a commit to timifasubaa/incubator-superset that referenced this pull request May 31, 2018
* [setup] Dropping 3.4 and 3.6

* Update tox.ini

* Update .travis.yml
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
* [setup] Dropping 3.4 and 3.6

* Update tox.ini

* Update .travis.yml
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants