-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[epoch] Remove non-UTC epoch logic #7667
[epoch] Remove non-UTC epoch logic #7667
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7667 +/- ##
==========================================
- Coverage 73.92% 65.58% -8.35%
==========================================
Files 106 435 +329
Lines 11444 21749 +10305
Branches 0 2394 +2394
==========================================
+ Hits 8460 14264 +5804
- Misses 2984 7364 +4380
- Partials 0 121 +121
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but perhaps add a comment in the changelog in case someone has logic depending on the incorrect epoch format?
e93f33b
to
f80712b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -23,6 +23,9 @@ assists people when migrating to a new version. | |||
|
|||
## Next Version | |||
|
|||
* [7667](https://github.com/apache/incubator-superset/pull/7667): a change to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove the "to" before reference
a change to make Unix (epoch) timestamps reference UTC as opposed to the local time zone.
2f06959
to
d14586c
Compare
@agrawaldevesh are you onboard with this change? |
d14586c
to
6dfdde0
Compare
3d290e4
to
e666244
Compare
PR apache#8450: Making client time use UTC as the local time PR apache#7667: Remove non-UTC epoch logic
PR apache#8450: Making client time use UTC as the local time PR apache#7667: Remove non-UTC epoch logic
CATEGORY
Choose one
SUMMARY
As @agrawaldevesh correctly identified in #6721 previously we were computing the Unix timestamp for the right-hand-side (RHS) of the temporal filter condition using the local time zone as opposed to UTC which is the definition of a Unix timestamp (or epoch).
@agrawaldevesh's change was behind a feature flag and disabled by default however this clearly is a bug and I sense we should remedy the problem by merely replacing the previously incorrect logic. Note I strongly believe users were probably unaware of the issue as Unix timestamps aren't human readable.
TEST PLAN
CI.
ADDITIONAL INFORMATION
REVIEWERS
to: @agrawaldevesh @betodealmeida @michellethomas @mistercrunch @villebro