-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable deprecated druid connector by default #8512
Disable deprecated druid connector by default #8512
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be a breaking change, checked docs and there is a note already but without a version target for removal. We should add a note on UPDATING.md.
Tests are failing, prob just need update, removing the now non existent permissions
@willbarrett it’s not deprecated yet, however there is merit in swaying new installations to prefer Druid SQL over the legacy native JSON-based query API. For context the deprecation of the native Druid connector is discussed in SIP-11. |
Thanks for the link @john-bodley - did that SIP go through an Apache vote process? Do you know if it was approved? |
@willbarrett the SIP hasn't been voted on and there was some initial push back due to non-feature parity. I know that Druid SQL is evolving but I'm uncertain whether all sketches (and other unique features) are supported. Note for context at Airbnb we're hoping to migrate away from the native Druid connector to Druid SQL and I'm currently working on a feasibility study and documenting what needs to happen in order to migrate a chart between the connectors. I may share a sanitized version of the doc with the community. |
OK. I need to think about how to handle this situation appropriately. I'm going to leave this PR as-is for a while. |
Sketches seem to be supported, check out the I'd still change the default, and add a line in |
2be5d5f
to
0c305aa
Compare
Codecov Report
@@ Coverage Diff @@
## master #8512 +/- ##
=========================================
- Coverage 65.76% 65.7% -0.06%
=========================================
Files 482 482
Lines 23824 23834 +10
Branches 2594 2594
=========================================
- Hits 15667 15661 -6
- Misses 7984 8000 +16
Partials 173 173
Continue to review full report at Codecov.
|
# Druid supports a SQL interface in its newer versions. | ||
# Setting this flag to True enables the deprecated, API-based Druid | ||
# connector. This feature may be removed at a future date. | ||
DRUID_IS_ACTIVE = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@willbarret apologies for not mentioning this sooner but can we rename this to something more specific, i.e., DRUID_NATIVE_IS_ACTIVE
or DRUID_NOSQL_IS_ACTIVE
?
CATEGORY
Choose one
SUMMARY
I've been informed by @mistercrunch that the Druid connector is deprecated in favor of the Druid SQLAlchemy engine. After a recent PR ( #8482 ) re-enabled the function of the
DRUID_IS_ACTIVE
flag, I figured I'd follow through and enshrine the deprecation in code by defaultingDRUID_IS_ACTIVE
toFalse
.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION
REVIEWERS
@mistercrunch @dpgaspar @betodealmeida