-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add protocol to cache warmup #8721
Conversation
@@ -60,7 +60,7 @@ import { | |||
LineMultiChartPlugin, | |||
PieChartPlugin, | |||
TimePivotChartPlugin, | |||
} from '@superset-ui/legacy-preset-chart-nvd3/lib'; | |||
} from '@superset-ui/legacy-preset-chart-nvd3/src'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will revert this.
We probably want to add a note to |
I'll do that. Here I'm assuming that if they didn't change |
Codecov Report
@@ Coverage Diff @@
## master #8721 +/- ##
==========================================
- Coverage 65.55% 65.54% -0.02%
==========================================
Files 482 482
Lines 24083 24096 +13
Branches 2763 2763
==========================================
+ Hits 15788 15793 +5
- Misses 8115 8123 +8
Partials 180 180
Continue to review full report at Codecov.
|
CATEGORY
Choose one
SUMMARY
We have two variables in
config.py
that are used exclusively for the cache warmup celery task:The change from
requests
tourllib
broke the task, sinceurllib
requires a protocol in addition to the host and port.I fixed it by adding a new variable to
config.py
:And using that variable when composing the URL.
TEST PLAN
Updated unit tests.
ADDITIONAL INFORMATION
This PR fixes #8461.
REVIEWERS
@willbarrett