fix: Add type specific date truncation functions to BigQuery #9238
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
Superset currently only supports having a common truncation function for time grain expressions. BigQuery, on the other hand, requires type-specific truncation functions for all temporal types:
https://cloud.google.com/bigquery/docs/reference/standard-sql/functions-and-operators#time_trunc
https://cloud.google.com/bigquery/docs/reference/standard-sql/functions-and-operators#date_trunc
https://cloud.google.com/bigquery/docs/reference/standard-sql/functions-and-operators#datetime_trunc
https://cloud.google.com/bigquery/docs/reference/standard-sql/functions-and-operators#timestamp_trunc
This PR adds the option to specify a type-specific truncation function denoted
{func}
in the time grain expression. For example, the time grain expression{func}({col}, HOUR)
with typeDATE
will yieldDATE_TRUNC(my_col, HOUR)
. Similarly,DATETIME
will yieldDATETIME_TRUNC(my_col, HOUR)
. This also renames the config optionTIME_GRAIN_ADDON_FUNCTIONS
toTIME_GRAIN_ADDON_EXPRESSIONS
, as they weren't really functions, but rather expressions.BEFORE
AFTER
(note
![image](https://user-images.githubusercontent.com/33317356/75903923-f9d07300-5e4a-11ea-870c-8f5b11b0c4d8.png)
DATETIME_TRUNC
instead ofTIMESTAMP_TRUNC
)TEST PLAN
CI + Tested locally.
ADDITIONAL INFORMATION
REVIEWERS