Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump python dependencies #9786

Merged
merged 10 commits into from
May 13, 2020
Merged

Conversation

villebro
Copy link
Member

@villebro villebro commented May 12, 2020

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

To ensure we're not missing out on security/bug fixes and general improvements, this PR bumps core dependencies to their latest stable versions. The biggest change is brought about by bumping werkzeug from 0.16 to 1.0.1, in which the contrib.cache module has been moved into its own PyPI package cachelib. The sqlalchemy-utils breaking change will need to be revisited later once the project decides on the appropriate path forward.

TEST PLAN

Local testing + CI

@codecov-io
Copy link

codecov-io commented May 12, 2020

Codecov Report

Merging #9786 into master will decrease coverage by 17.10%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #9786       +/-   ##
===========================================
- Coverage   70.82%   53.72%   -17.11%     
===========================================
  Files         587      352      -235     
  Lines       30435    11243    -19192     
  Branches     3121     2785      -336     
===========================================
- Hits        21555     6040    -15515     
+ Misses       8766     5023     -3743     
- Partials      114      180       +66     
Flag Coverage Δ
#cypress 53.72% <ø> (+0.06%) ⬆️
#javascript ?
#python ?
Impacted Files Coverage Δ
...uperset-frontend/src/dashboard/util/dnd-reorder.js 0.00% <0.00%> (-100.00%) ⬇️
...rset-frontend/src/dashboard/util/getEmptyLayout.js 0.00% <0.00%> (-100.00%) ⬇️
.../src/dashboard/util/getFilterScopeFromNodesTree.js 0.00% <0.00%> (-93.19%) ⬇️
.../src/dashboard/components/FilterIndicatorGroup.jsx 11.76% <0.00%> (-88.24%) ⬇️
...c/explore/components/controls/withVerification.jsx 9.09% <0.00%> (-87.88%) ⬇️
...src/dashboard/components/gridComponents/Header.jsx 10.52% <0.00%> (-86.85%) ⬇️
...rc/dashboard/components/gridComponents/Divider.jsx 13.33% <0.00%> (-86.67%) ⬇️
...c/dashboard/components/gridComponents/Markdown.jsx 6.59% <0.00%> (-82.42%) ⬇️
...uperset-frontend/src/utils/getClientErrorObject.ts 0.00% <0.00%> (-82.15%) ⬇️
superset-frontend/src/components/Link.tsx 7.69% <0.00%> (-79.81%) ⬇️
... and 367 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04e3a4a...05722e3. Read the comment docs.

@villebro villebro changed the title chore: bump pyhton dependencies chore: bump python dependencies May 12, 2020
requirements.txt Show resolved Hide resolved
requirements-dev.txt Outdated Show resolved Hide resolved
@villebro villebro requested a review from john-bodley May 13, 2020 12:26
@villebro villebro merged commit b532c46 into apache:master May 13, 2020
@etr2460
Copy link
Member

etr2460 commented May 18, 2020

@villebro, @bkyryliuk, it looks like this broke s3cache since s3werkzeugcache relies on the old werkzeug format. I'm going to work on a fix now, but I think i'll need help releasing a new version on pypi https://github.com/bkyryliuk/s3werkzeugcache

@Clockmaker
Copy link

Hi guys, updating to werkzeug 1.0.1, seems to break the oauth because SecurityManager is using flask-appbuilder that relies on flask-oauthlib using the old werkzeug's imports:

from werkzeug import url_quote, url_decode, url_encode

Right now, one workaround is to import cachelib and downgrading werkzeug.

Am I missing something?
I can also provide more logs if needed, but I should probably open a new issue, let me know.

@villebro
Copy link
Member Author

villebro commented Jun 1, 2020

Ping @dpgaspar

@anismiles
Copy link

Hi @Clockmaker, I am facing the same problem. Have you find a solution yet?

@villebro villebro deleted the villebro/bump-python branch November 15, 2021 10:09
@timesking
Copy link

s3cache

I got the same problem, may I ask how you work around it?

@MuslimBeibytuly
Copy link

Is this related?

2022-07-04 13:05:30,592:ERROR:root:'S3Cache' object has no attribute 'get'
Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/flask_appbuilder/api/__init__.py", line 85, in wraps
    return f(self, *args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/flask_appbuilder/api/__init__.py", line 155, in wraps
    return f(self, *args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/superset/utils/log.py", line 242, in wrapper
    value = f(*args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/superset/dashboards/api.py", line 833, in thumbnail
    screenshot = DashboardScreenshot(
  File "/usr/local/lib/python3.9/site-packages/superset/utils/screenshots.py", line 111, in get_from_cache
    return self.get_from_cache_key(cache, cache_key)
  File "/usr/local/lib/python3.9/site-packages/superset/utils/screenshots.py", line 116, in get_from_cache_key
    payload = cache.get(cache_key)
  File "/usr/local/lib/python3.9/site-packages/flask_caching/__init__.py", line 190, in get
    return self.cache.get(*args, **kwargs)
AttributeError: 'S3Cache' object has no attribute 'get'

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.37.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 0.37.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants