-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove indentation from statistics logging and print the data in tables #322
Conversation
FYI we had a quick poll about this and in the end we agreed we want to print this as a formatted table instead of JSON, so we won't be merging this one. Something like the following (but with snake_case instead of camelCase - this snippet was built based on the JS version)
|
We should be able to print tables using |
Thanks for your feedback! I am brand new to open source. I did make some furthers changes by using a table to print it out as a formatted table. Should I open a new PR or update this one? |
Awesome! Just commit the changes you made and push it to your fork and the PR will be updated automatically |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
The purpose of the PR is to fix the indentation of statistics logging. It was originally 8 space indentation but now it is changed to be all on one line.
Issues
This fixes issue #306
Testing
I went through the unit test files and logged out what the output would be for the statistics loggin.
Example:
Checklist
CHANGELOG.md