Fix workflows

apitally · Nov 21, 2023 · 3b24643 · 3b24643
1 parent 9990039
commit 3b24643
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 11 deletions.
diff --git a/.github/workflows/publish.yaml b/.github/workflows/publish.yaml
@@ -14,12 +14,17 @@ jobs:
         with:
           node-version: latest
           cache: npm
+          registry-url: https://registry.npmjs.org
       - name: Install dependencies
         run: npm ci
+      - name: Run checks
+        run: npm run check
+      - name: Run tests
+        run: npm test
       - name: Build package
         run: npm run build
       - name: Update version in package.json
-        run: npm version from-git
+        run: npm version from-git --no-git-tag-version
       - name: Publish to NPM
         run: npm publish
         env:

diff --git a/.github/workflows/tests.yaml b/.github/workflows/tests.yaml
@@ -21,10 +21,12 @@ jobs:
         with:
           node-version: latest
           cache: npm
-      - run: npm install --no-save express koa
-      - run: npm ci
-      - run: npm run check
-      - run: npm test -- --collectCoverage
+      - name: Install dependencies
+        run: npm ci
+      - name: Run checks
+        run: npm run check
+      - name: Run tests with coverage
+        run: npm test -- --collectCoverage
       - name: Upload coverage report to Codecov
         uses: codecov/codecov-action@v3
         with:
@@ -53,13 +55,19 @@ jobs:
         with:
           node-version: "${{ matrix.node }}"
           cache: npm
-      - run: npm ci
-      - run: npm install --no-save ${{ matrix.deps }}
-      - run: npm test -- tests/express
+      - name: Install dependencies
+        run: npm ci
+      - name: Override dependencies from matrix
+        run: npm install --no-save ${{ matrix.deps }}
+      - name: Run tests for Express
+        run: npm test -- tests/express
         if: contains(matrix.deps, 'express')
-      - run: npm test -- tests/fastify
+      - name: Run tests for Fastify
+        run: npm test -- tests/fastify
         if: contains(matrix.deps, 'fastify')
-      - run: npm test -- tests/koa
+      - name: Run tests for Koa
+        run: npm test -- tests/koa
         if: contains(matrix.deps, 'koa')
-      - run: npm test -- tests/nestjs
+      - name: Run tests for NestJS
+        run: npm test -- tests/nestjs
         if: contains(matrix.deps, 'nestjs')