Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting consumer name and group #23

Merged
merged 5 commits into from
Jul 7, 2024
Merged

Allow setting consumer name and group #23

merged 5 commits into from
Jul 7, 2024

Conversation

itssimon
Copy link
Member

@itssimon itssimon commented Jul 6, 2024

No description provided.

Copy link

codecov bot commented Jul 6, 2024

Codecov Report

Attention: Patch coverage is 81.90476% with 19 lines in your changes missing coverage. Please review.

Project coverage is 89.26%. Comparing base (152498b) to head (cb32519).

Files Patch % Lines
src/fastify/plugin.ts 63.15% 7 Missing ⚠️
src/express/middleware.ts 57.14% 6 Missing ⚠️
src/koa/middleware.ts 45.45% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
- Coverage   89.78%   89.26%   -0.52%     
==========================================
  Files          15       16       +1     
  Lines        1321     1407      +86     
  Branches      123      144      +21     
==========================================
+ Hits         1186     1256      +70     
- Misses        133      149      +16     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@itssimon itssimon merged commit 906f0da into main Jul 7, 2024
37 of 39 checks passed
@itssimon itssimon deleted the consumer-registry branch July 7, 2024 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant