-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include the compatible graphql version to incremental delivery docs #7834
Conversation
@thomaswelton: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
👷 Deploy request for apollo-server-docs pending review.Visit the deploys page to approve it
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the addition!
@thomaswelton did you confirm that |
For our test cases Alpha 2 works, we're now using defer in production |
@thomaswelton would you mind updating the couple references in the repo to |
@trevor-scheer Sure done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Updated the documentation on incremental delivery to include the specific prerelease version of graphQL that Apollo Server is compatible with for incremental delivery.
The current docs state "As of September 2022...", but a new pre release version was made available in 2023 https://github.com/graphql/graphql-js/releases/tag/v17.0.0-alpha.3 and this appears to contain a breaking change in the incremental payload delivery.