Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the compatible graphql version to incremental delivery docs #7834

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

thomaswelton
Copy link
Contributor

Updated the documentation on incremental delivery to include the specific prerelease version of graphQL that Apollo Server is compatible with for incremental delivery.

The current docs state "As of September 2022...", but a new pre release version was made available in 2023 https://github.com/graphql/graphql-js/releases/tag/v17.0.0-alpha.3 and this appears to contain a breaking change in the incremental payload delivery.

@apollo-cla
Copy link

@thomaswelton: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

Copy link

netlify bot commented Feb 13, 2024

👷 Deploy request for apollo-server-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 37957d9

Copy link

codesandbox-ci bot commented Feb 13, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

@Meschreiber Meschreiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition!

@trevor-scheer
Copy link
Member

@thomaswelton did you confirm that alpha.2 is working? We currently test against a specific canary, maybe we should update those references to alpha.2 as well.
i.e. our tests use graphql@17.0.0-alpha.1.canary.pr.3361.04ab27334641e170ce0e05bc927b972991953882

@thomaswelton
Copy link
Contributor Author

For our test cases Alpha 2 works, we're now using defer in production

@trevor-scheer
Copy link
Member

@thomaswelton would you mind updating the couple references in the repo to alpha.2? I can as well if you don't mind me pushing to your branch.

@thomaswelton
Copy link
Contributor Author

@trevor-scheer Sure done

Copy link
Member

@trevor-scheer trevor-scheer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@trevor-scheer trevor-scheer enabled auto-merge (squash) March 5, 2024 19:36
@trevor-scheer trevor-scheer merged commit 5704146 into apollographql:main Mar 5, 2024
16 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants