fix: usage of Optional.orElseThrow after Map.put #2145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artlomako
requested review from
mykola-mokhnach,
SrinivasanTarget,
saikrishna321 and
valfirst
as code owners
| @@ -19,6 +19,7 @@ | |||
| import java.util.Collections; | |||
| import java.util.HashMap; | |||
| import java.util.Map; | |||
| import java.util.Optional; | |||
There was a problem hiding this comment.
there is no need for this import
| @@ -83,8 +84,8 @@ public KeyEvent withFlag(KeyEventFlag keyEventFlag) { | |||
| */ | |||
| public Map<String, Object> build() { | |||
| var map = new HashMap<String, Object>(); | |||
| ofNullable(this.keyCode).map(x -> map.put("keycode", x)).orElseThrow(() -> new IllegalStateException( | |||
There was a problem hiding this comment.
@valfirst Could there be other places in the source like this one? I assume the issue may have been added during the recent refactoring
There was a problem hiding this comment.
yes, this is a regression issue, I've found 2 more similar occurrences, I'll open PR soon
There was a problem hiding this comment.
thanks. Lets address them all and publish a patch asap
There was a problem hiding this comment.
@mykola-mokhnach I believe I fixed them in my last commit
There was a problem hiding this comment.
I've already addressed AndroidGeoLocation issues here: #2146
artlomako
changed the title
|
@artlomako checkstyle is failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
KeyEventTypes of changes
What types of changes are you proposing/introducing to Java client?
Put an
xin the boxes that applyDetails
After the last change in
KeyEventclass, it's impossible to use the key event, because the following code always throws an exception:since
map.put()returns null for new key.