Avoid unnecessarily allocating an array when initializing String from a sequence of bytes

[fumoboy007]

No description provided.

[fumoboy007]

Will these changes automatically make it into the Darwin implementation once merged or do we need to create an Apple feedback report for that?

[parkera]

The Darwin implementation (and future everywhere implementation) is over here: https://github.com/apple/swift-foundation/blob/main/Sources/FoundationEssentials/String/String%2BEssentials.swift#L86

[fumoboy007]

Oh nice, it already has this optimization!

[fumoboy007]

@parkera Should we merge this?

[parkera]

@swift-ci test

[fumoboy007]

The macOS issue seems to be

CMake Error at CMakeLists.txt:11 (project):
  The CMAKE_C_COMPILER:

    /Users/ec2-user/jenkins/workspace/swift-corelibs-foundation-PR-macOS/branch-main/build/Ninja-ReleaseAssert/toolchain-macosx-x86_64/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang

  is not a full path to an existing compiler tool.

  Tell CMake where to find the compiler by setting either the environment
  variable "CC" or the CMake cache entry CMAKE_C_COMPILER to the full path to
  the compiler, or to the compiler name if it is in the PATH.

[MaxDesiatov]

@swift-ci test macos

[fumoboy007]

All checks passed!

[fumoboy007]

Happy New Year! Please review. 🙏