-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gas profiling of EntryPoints from transaction generator #11114
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @igor-aptos and the rest of your teammates on |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11114 +/- ##
=========================================
- Coverage 59.1% 59.0% -0.2%
=========================================
Files 827 828 +1
Lines 201015 201584 +569
=========================================
+ Hits 118830 118943 +113
- Misses 82185 82641 +456 ☔ View full report in Codecov by Sentry. |
73156c5
to
ef4659d
Compare
ef4659d
to
7e72df2
Compare
d1b6ccd
to
47ff097
Compare
7e72df2
to
9ce0fa8
Compare
47ff097
to
a53bf39
Compare
8d36b95
to
f0df36d
Compare
44293e5
to
cd83f39
Compare
// Confirm the index is not out of bounds. | ||
assert!(index < vector::length(&palette_.vec), error::invalid_argument(E_INDEX_OUT_OF_BOUNDS)); | ||
|
||
// Write the pixel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove?
let all_palettes = borrow_global<AllPalettes>(palette_addr); | ||
let palette_addr = vector::borrow(&all_palettes.all, palette_index); | ||
|
||
let palette_ = borrow_global_mut<Palette>(*palette_addr); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why the "_" suffix?
let execution = aggregated.ops.iter().map(|(_, _, v)| cast(*v)).sum::<f64>(); | ||
let read = aggregated.storage_reads.iter().map(|(_, _, v)| cast(*v)).sum::<f64>(); | ||
let write = aggregated.storage_writes.iter().map(|(_, _, v)| cast(*v)).sum::<f64>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: nicer to have these as methods on the AggregatedExecutionGasEvents
let profile_gas = match std::env::var("PROFILE_GAS") { | ||
Ok(s) => { | ||
let s = s.to_lowercase(); | ||
s != "0" && s != "false" && s != "no" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: it's counter intuitive to be able to enable a feature by setting a env var "nah". lol (I think we should match positive workds like "1", "yes", "true")
cd83f39
to
79b477b
Compare
d28c905
to
03b0e07
Compare
42cfb51
to
e63b2c0
Compare
03b0e07
to
0fd7ef6
Compare
42da298
to
3e902cb
Compare
b16d0ee
to
fc4583b
Compare
This issue is stale because it has been open 45 days with no activity. Remove the |
This issue is stale because it has been open 45 days with no activity. Remove the |
let txn = self.create_transaction_payload(account, payload); | ||
let (output, gas_log) = self | ||
.executor | ||
.execute_transaction_with_gas_profiler(txn) | ||
.unwrap(); | ||
// println!("output: {:?}", output); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm
This issue is stale because it has been open 45 days with no activity. Remove the |
fc4583b
to
0c7aef1
Compare
⏱️ 33h 37m total CI duration on this PR
🚨 1 job on the last run was significantly faster/slower than expected
|
2 similar comments
⏱️ 33h 37m total CI duration on this PR
🚨 1 job on the last run was significantly faster/slower than expected
|
⏱️ 33h 37m total CI duration on this PR
🚨 1 job on the last run was significantly faster/slower than expected
|
0c7aef1
to
161f945
Compare
362807e
to
7acd98b
Compare
7acd98b
to
2a4c159
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
Description
Test Plan