Gas profiling of EntryPoints from transaction generator #11114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @igor-aptos and the rest of your teammates on |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11114 +/- ##
=========================================
- Coverage 59.1% 59.0% -0.2%
=========================================
Files 827 828 +1
Lines 201015 201584 +569
=========================================
+ Hits 118830 118943 +113
- Misses 82185 82641 +456 ☔ View full report in Codecov by Sentry. |
igor-aptos
force-pushed
the
igor/gas_profiling_from_generator
branch
from
73156c5
to
ef4659d
Compare
igor-aptos
force-pushed
the
igor/gas_profiling_from_generator
branch
from
ef4659d
to
7e72df2
Compare
igor-aptos
force-pushed
the
igor/gas_schedule_update
branch
from
d1b6ccd
to
47ff097
Compare
igor-aptos
force-pushed
the
igor/gas_profiling_from_generator
branch
from
7e72df2
to
9ce0fa8
Compare
igor-aptos
force-pushed
the
igor/gas_schedule_update
branch
from
47ff097
to
a53bf39
Compare
igor-aptos
force-pushed
the
igor/gas_profiling_from_generator
branch
2 times, most recently
from
8d36b95
to
f0df36d
Compare
igor-aptos
force-pushed
the
igor/gas_profiling_from_generator
branch
3 times, most recently
from
44293e5
to
cd83f39
Compare
msmouse
approved these changes
Dec 6, 2023
| // Confirm the index is not out of bounds. | ||
| assert!(index < vector::length(&palette_.vec), error::invalid_argument(E_INDEX_OUT_OF_BOUNDS)); | ||
|
|
||
| // Write the pixel. |
| let all_palettes = borrow_global<AllPalettes>(palette_addr); | ||
| let palette_addr = vector::borrow(&all_palettes.all, palette_index); | ||
|
|
||
| let palette_ = borrow_global_mut<Palette>(*palette_addr); |
Comment on lines
39
to
40
| let execution = aggregated.ops.iter().map(|(_, _, v)| cast(*v)).sum::<f64>(); | ||
| let read = aggregated.storage_reads.iter().map(|(_, _, v)| cast(*v)).sum::<f64>(); | ||
| let write = aggregated.storage_writes.iter().map(|(_, _, v)| cast(*v)).sum::<f64>(); |
There was a problem hiding this comment.
nit: nicer to have these as methods on the AggregatedExecutionGasEvents
| let profile_gas = match std::env::var("PROFILE_GAS") { | ||
| Ok(s) => { | ||
| let s = s.to_lowercase(); | ||
| s != "0" && s != "false" && s != "no" |
There was a problem hiding this comment.
nit: it's counter intuitive to be able to enable a feature by setting a env var "nah". lol (I think we should match positive workds like "1", "yes", "true")
igor-aptos
force-pushed
the
igor/gas_profiling_from_generator
branch
from
cd83f39
to
79b477b
Compare
igor-aptos
force-pushed
the
igor/add_benchmark_workloads
branch
from
d28c905
to
03b0e07
Compare
igor-aptos
force-pushed
the
igor/gas_profiling_from_generator
branch
2 times, most recently
from
42cfb51
to
e63b2c0
Compare
igor-aptos
force-pushed
the
igor/add_benchmark_workloads
branch
from
03b0e07
to
0fd7ef6
Compare
igor-aptos
force-pushed
the
igor/gas_profiling_from_generator
branch
2 times, most recently
from
42da298
to
3e902cb
Compare
igor-aptos
force-pushed
the
igor/gas_profiling_from_generator
branch
from
b16d0ee
to
fc4583b
Compare
|
This issue is stale because it has been open 45 days with no activity. Remove the |
|
This issue is stale because it has been open 45 days with no activity. Remove the |
davidiw
approved these changes
Apr 23, 2024
| let txn = self.create_transaction_payload(account, payload); | ||
| let (output, gas_log) = self | ||
| .executor | ||
| .execute_transaction_with_gas_profiler(txn) | ||
| .unwrap(); | ||
| // println!("output: {:?}", output); |
|
This issue is stale because it has been open 45 days with no activity. Remove the |
igor-aptos
force-pushed
the
igor/gas_profiling_from_generator
branch
from
fc4583b
to
0c7aef1
Compare
⏱️ 33h 37m total CI duration on this PR
🚨 1 job on the last run was significantly faster/slower than expected
|
2 similar comments
⏱️ 33h 37m total CI duration on this PR
🚨 1 job on the last run was significantly faster/slower than expected
|
⏱️ 33h 37m total CI duration on this PR
🚨 1 job on the last run was significantly faster/slower than expected
|
igor-aptos
force-pushed
the
igor/gas_profiling_from_generator
branch
2 times, most recently
from
0c7aef1
to
161f945
Compare
igor-aptos
force-pushed
the
igor/gas_profiling_from_generator
branch
2 times, most recently
from
362807e
to
7acd98b
Compare
igor-aptos
force-pushed
the
igor/gas_profiling_from_generator
branch
from
7acd98b
to
2a4c159
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test Plan