Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Run proposal simulation for 1.16 on the new gas delta schedule #14028

Closed

Conversation

perryjrandall
Copy link
Contributor

@perryjrandall perryjrandall commented Jul 17, 2024

Slight changes to rebase cleanly

Testing:

cargo run -p aptos-release-builder generate-proposals --release-config data/release.yaml --output-dir output --simulate mainnet

Simulation still fails maybe due to latest cherry pick?

Creating and funding sender account.. done
Executing governance scripts...
    0-gas-schedule.move
        Success
    1-move-stdlib.move
        Success
    2-aptos-stdlib.move
        Success
    3-aptos-framework.move
        Keep(
            MiscellaneousError(
                Some(
                    BACKWARD_INCOMPATIBLE_MODULE_UPDATE,
                ),
            ),
        )
Error: failed to simulate proposal at output/sources/v1.16/step_1_upgrade_framework

Caused by:
    failed to execute governance script: 3-aptos-framework.move

Copy link

trunk-io bot commented Jul 17, 2024

⏱️ 4h 45m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-unit-tests 1h 58m 🟩🟩
test-fuzzers 1h 13m 🟩🟩
rust-move-tests 57m 🟩🟩🟩🟩
rust-lints 16m 🟥🟥🟥🟥
general-lints 8m 🟩🟩🟩🟩
run-tests-main-branch 7m 🟥🟥🟥🟥
check-dynamic-deps 3m 🟩🟩🟩🟩
semgrep/ci 1m 🟩🟩🟩🟩
file_change_determinator 51s 🟩🟩🟩🟩
file_change_determinator 45s 🟩🟩🟩🟩
permission-check 17s 🟩🟩🟩🟩
permission-check 13s 🟩🟩🟩🟩
permission-check 8s 🟩🟩🟩🟩
permission-check 8s 🟩🟩🟩🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

@perryjrandall perryjrandall marked this pull request as draft July 17, 2024 18:46
@perryjrandall perryjrandall changed the title perry/simulate transactions 1 16 [test] Run proposal simulation for 1.16 on the new gas delta schedule Jul 17, 2024
@perryjrandall perryjrandall force-pushed the perry/simulate-transactions-1-16 branch from cbb9c13 to 592e804 Compare July 17, 2024 19:19
vgao1996 and others added 2 commits July 19, 2024 20:02
Slight change to rebase cleanly

Testing:

```
cargo run -p aptos-release-builder generate-proposals --release-config data/release.yaml --output-dir output

cargo run -p aptos-release-builder simulate-multi-step-proposal --network mainnet --proposal-dir output/sources/v1.16/step_1_upgrade_framework/
```

Simulation output seems to fail, is this expected? Did we catch a potential difference?
https://gist.github.com/perryjrandall/80d5b7f26594412cf5ae3e523084258b
@perryjrandall perryjrandall force-pushed the perry/simulate-transactions-1-16 branch from 592e804 to 7d36fc9 Compare July 20, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants