-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[indexer] File store backfiller #14058
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
has this already finished backfilling in testnet ? |
nope; updated the description with current status. |
rtso
requested changes
Jul 24, 2024
ecosystem/indexer-grpc/indexer-grpc-file-store-backfiller/src/metrics.rs
Outdated
Show resolved
Hide resolved
ecosystem/indexer-grpc/indexer-grpc-file-store-backfiller/src/processor.rs
Show resolved
Hide resolved
ecosystem/indexer-grpc/indexer-grpc-file-store-backfiller/src/processor.rs
Show resolved
Hide resolved
ecosystem/indexer-grpc/indexer-grpc-file-store-backfiller/src/processor.rs
Outdated
Show resolved
Hide resolved
ecosystem/indexer-grpc/indexer-grpc-file-store-backfiller/src/processor.rs
Show resolved
Hide resolved
ecosystem/indexer-grpc/indexer-grpc-file-store-backfiller/src/processor.rs
Show resolved
Hide resolved
ecosystem/indexer-grpc/indexer-grpc-file-store-backfiller/src/processor.rs
Outdated
Show resolved
Hide resolved
ecosystem/indexer-grpc/indexer-grpc-file-store-backfiller/src/processor.rs
Show resolved
Hide resolved
42e1a3b
to
9167c72
Compare
9167c72
to
0080112
Compare
yuunlimm
approved these changes
Jul 31, 2024
ecosystem/indexer-grpc/indexer-grpc-file-store-backfiller/src/processor.rs
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ying-w
approved these changes
Jul 31, 2024
larry-aptos
commented
Jul 31, 2024
@@ -16,7 +16,7 @@ cargo build --locked --profile=$PROFILE \ | |||
-p aptos-indexer-grpc-file-store \ | |||
-p aptos-indexer-grpc-data-service \ | |||
-p aptos-nft-metadata-crawler-parser \ | |||
-p aptos-indexer-grpc-in-memory-cache-benchmark \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is replaced by @just-in-chang's work.
rtso
approved these changes
Jul 31, 2024
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CICD:build-images
when this label is present github actions will start build+push rust images from the PR.
CICD:build-indexer-images
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create a file store backfiller. This consumes data from an archive fullnode.
Type of Change
Which Components or Systems Does This Change Impact?
How Has This Been Tested?
Tested in testnet and mainnet; looks good.
Key Areas to Review
Checklist