-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add chain gap/pause analysis from onchain data to CLI #14061
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 16m total CI duration on this PR
|
15f95cc
to
e505bcb
Compare
msmouse
approved these changes
Jul 23, 2024
bchocho
approved these changes
Aug 5, 2024
|| gap_info.non_epoch_time_gap.max_gap > chain_progress_threshold.max_non_epoch_no_progress_secs { | ||
bail!("Failed non-epoch-change chain progress check. {}", &gap_text); | ||
} | ||
println!("Passed non-epoch-change progress check. {}", gap_text); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason println is used here and info above?
5ce3999
to
2a15732
Compare
2a15732
to
5924a44
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
analyze-validator-performance --analyze-mode network-health-over-time
cli command gives health statistics of the network over time. Adding gap analysis to it as well, as an useful metric if there are any issues or notType of Change
Which Components or Systems Does This Change Impact?
How Has This Been Tested?
cargo run -p aptos -- node analyze-validator-performance --analyze-mode network-health-over-time --url https://fullnode.mainnet.aptoslabs.com/ --start-epoch=-12
returns
Checklist