Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V117 randomness module update #14062

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

zjma
Copy link
Contributor

@zjma zjma commented Jul 19, 2024

cherry-picking #14056

Copy link

trunk-io bot commented Jul 19, 2024

⏱️ 7h 15m total CI duration on this PR
Job Cumulative Duration Recent Runs
forge-e2e-test / forge 1h 35m 🟩🟥🟩🟥🟩 (+2 more)
forge-compat-test / forge 1h 17m 🟥🟩🟩🟩🟩 (+1 more)
rust-unit-tests 41m 🟩
rust-unit-tests 40m 🟩
rust-unit-tests 22m 🟩
rust-unit-tests 22m 🟩
rust-unit-tests 19m 🟥
check 18m 🟩🟩🟩🟩🟩
test-target-determinator 15m 🟥🟥🟥🟥🟥
rust-move-unit-coverage 15m 🟩
rust-move-unit-coverage 13m 🟩
execution-performance / test-target-determinator 13m 🟥🟥🟥🟥🟥
check-dynamic-deps 8m 🟩🟩🟩🟩🟩 (+1 more)
general-lints 8m 🟩🟩🟩🟩🟩 (+1 more)
rust-cargo-deny 7m 🟩🟩🟩🟩🟥 (+1 more)
rust-move-tests 3m 🟥
rust-move-tests 3m 🟥
rust-move-tests 3m 🟥
rust-move-tests 3m 🟥
rust-move-tests 3m 🟥
semgrep/ci 2m 🟩🟩🟩🟩🟩 (+1 more)
file_change_determinator 1m 🟩🟩🟩🟩🟩 (+1 more)
file_change_determinator 1m 🟩🟩🟩🟩🟩 (+1 more)
file_change_determinator 1m 🟩🟩🟩🟩🟩
permission-check 21s 🟩🟩🟩🟩🟩 (+1 more)
permission-check 21s 🟩🟩🟩🟩🟩 (+1 more)
permission-check 19s 🟩🟩🟩🟩🟩
determine-docker-build-metadata 18s 🟩🟩🟩🟩🟩
permission-check 18s 🟩🟩🟩🟩🟩 (+1 more)
permission-check 13s 🟩🟩🟩🟩🟩 (+1 more)
rust-move-tests 9s

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
general-lints 3s 2m -97%

settingsfeedbackdocs ⋅ learn more about trunk.io

@zjma zjma changed the base branch from main to aptos-release-v1.17 July 19, 2024 22:57
@zjma zjma marked this pull request as ready for review July 19, 2024 22:58
@zjma zjma enabled auto-merge (squash) July 19, 2024 22:58
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (aptos-release-v1.17@5eb497f). Learn more about missing BASE report.

Additional details and impacted files
@@                  Coverage Diff                   @@
##             aptos-release-v1.17   #14062   +/-   ##
======================================================
  Coverage                       ?    59.0%           
======================================================
  Files                          ?      822           
  Lines                          ?   198161           
  Branches                       ?        0           
======================================================
  Hits                           ?   117008           
  Misses                         ?    81153           
  Partials                       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@zjma zjma requested a review from alinush July 22, 2024 16:22
@sherry-x sherry-x disabled auto-merge July 23, 2024 00:08
@sherry-x sherry-x enabled auto-merge (rebase) July 23, 2024 00:08

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@zjma zjma disabled auto-merge July 23, 2024 04:00
@zjma zjma enabled auto-merge (squash) July 23, 2024 04:00

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> 82e12736085447742fe217deacd3d6007c893b61

Compatibility test results for 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> 82e12736085447742fe217deacd3d6007c893b61 (PR)
1. Check liveness of validators at old version: 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5
compatibility::simple-validator-upgrade::liveness-check : committed: 8380.607912128675 txn/s, latency: 3868.5442958397534 ms, (p50: 2700 ms, p90: 6300 ms, p99: 28700 ms), latency samples: 324500
2. Upgrading first Validator to new version: 82e12736085447742fe217deacd3d6007c893b61
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6543.816697675663 txn/s, latency: 4188.567112 ms, (p50: 4800 ms, p90: 5100 ms, p99: 5300 ms), latency samples: 125000
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7006.096769680509 txn/s, latency: 4603.573821308725 ms, (p50: 4600 ms, p90: 5400 ms, p99: 6300 ms), latency samples: 238400
3. Upgrading rest of first batch to new version: 82e12736085447742fe217deacd3d6007c893b61
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7287.464487033719 txn/s, latency: 3673.4441296134846 ms, (p50: 4100 ms, p90: 4400 ms, p99: 4500 ms), latency samples: 137640
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6617.638171028135 txn/s, latency: 4565.428096432327 ms, (p50: 4300 ms, p90: 7600 ms, p99: 8200 ms), latency samples: 247220
4. upgrading second batch to new version: 82e12736085447742fe217deacd3d6007c893b61
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11038.79509298609 txn/s, latency: 2600.455443507927 ms, (p50: 2900 ms, p90: 3100 ms, p99: 3400 ms), latency samples: 199320
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10061.888866826508 txn/s, latency: 3270.9288178800093 ms, (p50: 3100 ms, p90: 4400 ms, p99: 6800 ms), latency samples: 337360
5. check swarm health
Compatibility test for 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> 82e12736085447742fe217deacd3d6007c893b61 passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 82e12736085447742fe217deacd3d6007c893b61

two traffics test: inner traffic : committed: 9428.35321857112 txn/s, latency: 4222.88518145555 ms, (p50: 4200 ms, p90: 4500 ms, p99: 9900 ms), latency samples: 3584900
two traffics test : committed: 99.90296873577756 txn/s, latency: 2400.3172413793104 ms, (p50: 2100 ms, p90: 3200 ms, p99: 3900 ms), latency samples: 1740
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.238, avg: 0.220", "QsPosToProposal: max: 1.768, avg: 1.695", "ConsensusProposalToOrdered: max: 0.314, avg: 0.291", "ConsensusOrderedToCommit: max: 0.393, avg: 0.379", "ConsensusProposalToCommit: max: 0.681, avg: 0.670"]
Max round gap was 1 [limit 4] at version 1975551. Max no progress secs was 5.793511 [limit 15] at version 1975551.
Test Ok

@sherry-x sherry-x disabled auto-merge July 23, 2024 17:51
@sherry-x sherry-x merged commit e8d0878 into aptos-release-v1.17 Jul 23, 2024
49 of 55 checks passed
@sherry-x sherry-x deleted the v117-randomness-module-update branch July 23, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants