Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

randomness.move update #14063

Merged
merged 1 commit into from
Jul 23, 2024
Merged

randomness.move update #14063

merged 1 commit into from
Jul 23, 2024

Conversation

zjma
Copy link
Contributor

@zjma zjma commented Jul 19, 2024

cherry picking #14056 to main.

@zjma zjma marked this pull request as ready for review July 19, 2024 23:02
@zjma zjma enabled auto-merge (squash) July 19, 2024 23:02
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.9%. Comparing base (0f49e1c) to head (538895d).
Report is 16 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (0f49e1c) and HEAD (538895d). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (0f49e1c) HEAD (538895d)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main   #14063       +/-   ##
===========================================
- Coverage    71.5%    58.9%    -12.6%     
===========================================
  Files        2330      824     -1506     
  Lines      460902   198033   -262869     
===========================================
- Hits       329781   116770   -213011     
+ Misses     131121    81263    -49858     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> 538895d5c664649f8ebeda14ef68e90b2196b50e

Compatibility test results for 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> 538895d5c664649f8ebeda14ef68e90b2196b50e (PR)
1. Check liveness of validators at old version: 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5
compatibility::simple-validator-upgrade::liveness-check : committed: 9976.485082097059 txn/s, latency: 3498.0605619790267 ms, (p50: 2700 ms, p90: 6600 ms, p99: 17100 ms), latency samples: 371900
2. Upgrading first Validator to new version: 538895d5c664649f8ebeda14ef68e90b2196b50e
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7251.725997519493 txn/s, latency: 3699.865315963725 ms, (p50: 4100 ms, p90: 4400 ms, p99: 4500 ms), latency samples: 138940
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6445.192442714033 txn/s, latency: 4626.052002120372 ms, (p50: 4600 ms, p90: 5400 ms, p99: 6000 ms), latency samples: 245240
3. Upgrading rest of first batch to new version: 538895d5c664649f8ebeda14ef68e90b2196b50e
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7566.326229169842 txn/s, latency: 3502.769405059772 ms, (p50: 3900 ms, p90: 4200 ms, p99: 4400 ms), latency samples: 143880
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6625.130088931628 txn/s, latency: 4790.724009297363 ms, (p50: 4400 ms, p90: 8300 ms, p99: 9500 ms), latency samples: 262440
4. upgrading second batch to new version: 538895d5c664649f8ebeda14ef68e90b2196b50e
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11449.679935846027 txn/s, latency: 2324.031889378365 ms, (p50: 2500 ms, p90: 2800 ms, p99: 3100 ms), latency samples: 204300
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 11147.212492035933 txn/s, latency: 3232.896684037301 ms, (p50: 3200 ms, p90: 4000 ms, p99: 4900 ms), latency samples: 364600
5. check swarm health
Compatibility test for 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> 538895d5c664649f8ebeda14ef68e90b2196b50e passed
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> 538895d5c664649f8ebeda14ef68e90b2196b50e

Compatibility test results for 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> 538895d5c664649f8ebeda14ef68e90b2196b50e (PR)
Upgrade the nodes to version: 538895d5c664649f8ebeda14ef68e90b2196b50e
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1235.1453706986576 txn/s, submitted: 1237.1496633894467 txn/s, failed submission: 2.004292690788897 txn/s, expired: 2.004292690788897 txn/s, latency: 3268.0164705882353 ms, (p50: 2100 ms, p90: 6300 ms, p99: 12400 ms), latency samples: 98600
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1010.7051366069662 txn/s, submitted: 1012.0992126574586 txn/s, failed submission: 1.3940760504923673 txn/s, expired: 1.3940760504923673 txn/s, latency: 3407.2335747126435 ms, (p50: 2100 ms, p90: 6600 ms, p99: 13900 ms), latency samples: 87000
5. check swarm health
Compatibility test for 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> 538895d5c664649f8ebeda14ef68e90b2196b50e passed
Upgrade the remaining nodes to version: 538895d5c664649f8ebeda14ef68e90b2196b50e
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1058.327361914283 txn/s, submitted: 1061.3905380703302 txn/s, failed submission: 3.0631761560471293 txn/s, expired: 3.0631761560471293 txn/s, latency: 2850.660864172007 ms, (p50: 2100 ms, p90: 5100 ms, p99: 10200 ms), latency samples: 96740
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 538895d5c664649f8ebeda14ef68e90b2196b50e

two traffics test: inner traffic : committed: 9178.188775298308 txn/s, submitted: 9406.950476650112 txn/s, failed submission: 0.15254286822723234 txn/s, expired: 228.76170135180465 txn/s, latency: 2902.9343621587855 ms, (p50: 2800 ms, p90: 3600 ms, p99: 4300 ms), latency samples: 3489740
two traffics test : committed: 100.0743098677343 txn/s, latency: 1877.2605 ms, (p50: 2000 ms, p90: 2200 ms, p99: 2300 ms), latency samples: 2000
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.247, avg: 0.220", "QsPosToProposal: max: 1.323, avg: 0.697", "ConsensusProposalToOrdered: max: 0.331, avg: 0.298", "ConsensusOrderedToCommit: max: 0.417, avg: 0.400", "ConsensusProposalToCommit: max: 0.712, avg: 0.697"]
Max round gap was 1 [limit 4] at version 175539. Max no progress secs was 5.735814 [limit 15] at version 2995801.
Test Ok

@zjma zjma requested a review from alinush July 23, 2024 17:52
@zjma zjma merged commit f01f26e into main Jul 23, 2024
95 of 105 checks passed
@zjma zjma deleted the zjma/randomness-module-update branch July 23, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants