[Framework] Add dependencies check for code object freezing #14064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
movekevin
force-pushed
the
freeze-fix
branch
3 times, most recently
from
3850c4f
to
cc9b120
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14064 +/- ##
===========================================
- Coverage 71.5% 58.9% -12.6%
===========================================
Files 2330 824 -1506
Lines 460902 198033 -262869
===========================================
- Hits 329781 116770 -213011
+ Misses 131121 81263 -49858 ☔ View full report in Codecov by Sentry. |
junkil-park
reviewed
Jul 20, 2024
| // This would increase the amount of gas used, but this is a rare operation and it's rare to have many packages | ||
| // in a single code object. | ||
| vector::for_each(registry.packages, |pack| { | ||
| check_dependencies(code_object_addr, &pack); |
There was a problem hiding this comment.
This check_dependencies function returns allowed_module_deps that are normally used in the native bytecode dep verification:
Is it fine to ignore the return value?
There was a problem hiding this comment.
Yeah here in this freeze function we only care about visibility checks as other checks should have already been performed when this package was first deployed or last updated
|
LGTM, maybe one more test to verify freezing an upgradeable/mutable package with immutable dependencies should work too. Edit: Added this in! |
junkil-park
approved these changes
Jul 22, 2024
davidiw
approved these changes
Jul 22, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
junkil-park
pushed a commit
that referenced
this pull request
Jul 22, 2024
* Refactor object deployment CLI commands * Refactor object deployment CLI commands --------- Co-authored-by: JohnChangUK <[email protected]>
movekevin
added a commit
that referenced
this pull request
Jul 22, 2024
…14079) * Refactor object deployment CLI commands * Refactor object deployment CLI commands --------- Co-authored-by: Kevin <[email protected]> Co-authored-by: JohnChangUK <[email protected]>
junkil-park
pushed a commit
that referenced
this pull request
Jul 23, 2024
* Refactor object deployment CLI commands * Refactor object deployment CLI commands --------- Co-authored-by: JohnChangUK <[email protected]>
fEst1ck
pushed a commit
to fEst1ck/aptos-core
that referenced
this pull request
Jul 23, 2024
…bs#14064) * Refactor object deployment CLI commands * Refactor object deployment CLI commands --------- Co-authored-by: JohnChangUK <[email protected]>
sherry-x
pushed a commit
that referenced
this pull request
Jul 23, 2024
* Refactor object deployment CLI commands * Refactor object deployment CLI commands --------- Co-authored-by: JohnChangUK <[email protected]>
sherry-x
pushed a commit
that referenced
this pull request
Jul 23, 2024
* Refactor object deployment CLI commands * Refactor object deployment CLI commands --------- Co-authored-by: JohnChangUK <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Which Components or Systems Does This Change Impact?
How Has This Been Tested?
E2E tests
Key Areas to Review
Checklist