Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dcl known functions to @radspec helper #87

Merged
merged 2 commits into from
Jan 23, 2020

Conversation

nachomazzara
Copy link
Contributor

I have added some functions to be tested by the agent.

'setOwnerCutPerMillion(uint256)': 'Set marketplace fees to `$1 / 1000000`%',
  'transferMarketplaceOwnership(address)':
    'Transfer ownership of the marketplace to `$1`',
  'transferOwnership(address)': 'Transfer ownership of the contract to `$1`',
  'pause()': 'Pause contract',
  'unpause()': 'Unpause Contract`'

@claassistantio
Copy link

claassistantio commented Jan 21, 2020

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

coveralls commented Jan 21, 2020

Coverage Status

Coverage increased (+0.04%) to 89.773% when pulling 0caa3a8 on nachomazzara:feat/add-dcl-known-functions into e306a11 on aragon:master.

Copy link
Contributor

@sohkai sohkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I've also added a small test to make sure we're handling it correctly!

@sohkai sohkai changed the title feat: add dcl known functions * feat: add dcl known functions to @radspec helper Jan 23, 2020
@sohkai sohkai merged commit debb71c into aragon:master Jan 23, 2020
@sohkai sohkai changed the title * feat: add dcl known functions to @radspec helper feat: add dcl known functions to @radspec helper Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants