[#21] Fix crash at the cost of some correctness #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Band-aid for issue #21. Will no longer crash, but will not collapse some names for template analysis, and mis-collapse others.
At present, this only seems to affect "Function sets that took longest to compile / optimize". So it is possible that users will still get oddly collapsed names in those reports. The more likely outcome is that the mis-collapsed names won't get an opportunity to merge with other similar templates, so their score won't even show up in the list, even if it was part of a very expensive set of templates to optimize.