Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a UB in BufferedWriter::Write #66

Merged
merged 1 commit into from
Mar 15, 2021
Merged

Fix a UB in BufferedWriter::Write #66

merged 1 commit into from
Mar 15, 2021

Conversation

vitaut
Copy link
Contributor

@vitaut vitaut commented Mar 15, 2021

Fix a UB in BufferedWriter::Write:

    #0 0x44c318 in BufferedWriter::Write(void const*, unsigned long) .../BuildEvents.cpp:473
    #1 0x44b615 in SaveBuildEvents(BuildEventsParser*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) .../BuildEvents.cpp:556
    #2 0x59b0ca in ProcessJsonFiles(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, long, long) .../main.cpp:194
    ...

which is caused by passing a null pointer to memcpy.

@aras-p aras-p merged commit 4ab14f2 into aras-p:master Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants