Feature/cloud/improve post process #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mprove-post-process
- Cleanup of pkl at start of workflow - Forced pkl save process in case of error in post_process.py
- update ProcessType define - minor improvement
- minor improvement
- BE) update WorkflowResult for support PostProcessResult - FE) update post process result check request
2 tasks
This was referenced Jul 10, 2024
emuemuJP
reviewed
Jul 10, 2024
| # Operate remote storage. | ||
| if RemoteStorageController.use_remote_storage(): | ||
| # Get workspace_id, unique_id from output file path | ||
| workspace_id, unique_id = __rule.output.split("/")[-4:-2] |
There was a problem hiding this comment.
他の部分でも出てくるようなら専用のパーサ関数を書いてもいいかもしれません
There was a problem hiding this comment.
現行コードの類似コードを踏襲していましたが（output_pathよりid情報を取得）、ご指摘のように関数化が適切なロジックのため、他の箇所と合わせて整理を行います。（別途 refactoring PR を発行予定）
- 現行の類似コード例
There was a problem hiding this comment.
@emuemuJP
以下で、上記のreview指摘に関する修正PRを作成しています。
上記PRがOKであれば、同内容を こちらにも反映します。
There was a problem hiding this comment.
以下にて修正を適用
…rser Add a parser for each ID in the experiment output data path
- add note comment - added use of ExptOutputPathIds
itutu-tienday
commented
Jul 11, 2024
| # Operate remote storage. | ||
| if RemoteStorageController.use_remote_storage(): | ||
| # Get workspace_id, unique_id from output file path | ||
| workspace_id, unique_id = __rule.output.split("/")[-4:-2] |
There was a problem hiding this comment.
以下にて修正を適用
emuemuJP
approved these changes
Jul 16, 2024
…mprove-post-process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contents
GUI Changes
post_processprocessing results display to the Experiment Table on the RECORD screen