Merge branch 'devel' into varpv6_ipv6enable

aristanetworks · Jul 29, 2024 · 1b6be9c · 1b6be9c
2 parents 981e15c + 32cd355
commit 1b6be9c
Show file tree

Hide file tree

Showing 287 changed files with 6,927 additions and 718 deletions.
diff --git a/.gitattributes b/.gitattributes
@@ -1,14 +1,12 @@
 # Collapsing generated schemas from PR diff by default
-/ansible_collections/arista/avd/roles/eos_cli_config_gen/schemas/eos_cli_config_gen.schema.yml  linguist-generated=true -merge -diff
-/ansible_collections/arista/avd/roles/eos_cli_config_gen/schemas/eos_cli_config_gen.jsonschema.json  linguist-generated=true -merge -diff
-/ansible_collections/arista/avd/roles/eos_cli_config_gen/schemas/eos_cli_config_gen.schema.pickle  linguist-generated=true merge=union -diff -text
-/ansible_collections/arista/avd/roles/eos_designs/schemas/eos_designs.schema.yml  linguist-generated=true -merge -diff
-/ansible_collections/arista/avd/roles/eos_designs/schemas/eos_designs.jsonschema.json  linguist-generated=true -merge -diff
-/ansible_collections/arista/avd/roles/eos_designs/schemas/eos_designs.schema.pickle  linguist-generated=true merge=union -diff -text
+/python-avd/pyavd/_eos_cli_config_gen/schema/eos_cli_config_gen.schema.yml  linguist-generated=true -merge -diff
+/python-avd/pyavd/_eos_cli_config_gen/schema/eos_cli_config_gen.jsonschema.json  linguist-generated=true -merge -diff
+/python-avd/pyavd/_eos_designs/schema/eos_designs.schema.yml  linguist-generated=true -merge -diff
+/python-avd/pyavd/_eos_designs/schema/eos_designs.jsonschema.json  linguist-generated=true -merge -diff
 
-# Collapsing generated tables from PR diff by default
-/ansible_collections/arista/avd/roles/eos_cli_config_gen/tables/*  linguist-generated=true -merge -diff
-/ansible_collections/arista/avd/roles/eos_designs/tables/*  linguist-generated=true -merge -diff
+# Showing generated tables in PR diff by default by count as generated and automatically use the latest file on merge
+/ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/*  linguist-generated=true -merge diff
+/ansible_collections/arista/avd/roles/eos_designs/docs/tables/*  linguist-generated=true -merge diff
 
 # Collapsing generated plugins doc from PR diff by default
 /ansible_collections/arista/avd/docs/plugins/*  linguist-generated=true
@@ -19,3 +17,6 @@
 # Excluding docs from stats for linguist
 /ansible_collections/arista/avd/roles/*/docs/*  linguist-documentation
 /ansible_collections/arista/avd/docs/*  linguist-documentation
+
+# CV API files are generated from proto files
+/python-avd/pyavd/_cv/api  linguist-generated=true
diff --git a/.github/workflows/new-cvp-integration.yml b/.github/workflows/new-cvp-integration.yml
@@ -29,7 +29,7 @@ jobs:
       - name: Run molecule action
         env:
           CVAAS_AAWG_CI: ${{ secrets.CVAAS_AAWG_CI }}
-        uses: arista-netdevops-community/action-molecule-avd@v1.7
+        uses: arista-netdevops-community/action-molecule-avd@v1.8.1
         with:
           molecule_parentdir: 'ansible_collections/arista/avd'
           molecule_command: 'test'
@@ -62,7 +62,7 @@ jobs:
       - name: Run molecule action
         env:
           CVAAS_AAWG_CI: ${{ secrets.CVAAS_AAWG_CI }}
-        uses: arista-netdevops-community/action-molecule-avd@v1.7
+        uses: arista-netdevops-community/action-molecule-avd@v1.8.1
         with:
           molecule_parentdir: 'ansible_collections/arista/avd'
           molecule_command: 'test'

diff --git a/.github/workflows/pull-request-comment.yml b/.github/workflows/pull-request-comment.yml
@@ -31,6 +31,8 @@ jobs:
             source test-avd-pr-${{ github.event.pull_request.number }}/bin/activate
             # Install all requirements including PyAVD
             pip install "pyavd[ansible] @ git+${{ github.event.pull_request.head.repo.clone_url }}@${{ github.event.pull_request.head.ref }}#subdirectory=python-avd" --force
+            # Point Ansible collections path to the Python virtual environment
+            export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
             # Install Ansible collection
             ansible-galaxy collection install git+${{ github.event.pull_request.head.repo.clone_url }}#/ansible_collections/arista/avd/,${{ github.event.pull_request.head.ref }} --force
             # Optional: Install AVD examples

diff --git a/.github/workflows/pull-request-management.yml b/.github/workflows/pull-request-management.yml
@@ -141,7 +141,7 @@ jobs:
           echo "ANSIBLE_FORCE_COLOR=1" >> $GITHUB_ENV
       - uses: actions/checkout@v4
       - name: Run molecule action
-        uses: arista-netdevops-community/action-molecule-avd@v1.7
+        uses: arista-netdevops-community/action-molecule-avd@v1.8.1
         with:
           molecule_parentdir: 'ansible_collections/arista/avd'
           molecule_command: 'test'
@@ -176,7 +176,7 @@ jobs:
           echo "ANSIBLE_FORCE_COLOR=1" >> $GITHUB_ENV
       - uses: actions/checkout@v4
       - name: Run molecule action
-        uses: arista-netdevops-community/action-molecule-avd@v1.7
+        uses: arista-netdevops-community/action-molecule-avd@v1.8.1
         with:
           molecule_parentdir: 'ansible_collections/arista/avd'
           molecule_command: 'test'
@@ -247,7 +247,7 @@ jobs:
           cat ${{ matrix.pip_requirements }}
         if: matrix.pip_requirements == 'tmp-requirements-minimum.txt'
       - name: Run molecule action
-        uses: arista-netdevops-community/action-molecule-avd@v1.7
+        uses: arista-netdevops-community/action-molecule-avd@v1.8.1
         with:
           molecule_parentdir: 'ansible_collections/arista/avd'
           molecule_command: 'test'
@@ -286,7 +286,7 @@ jobs:
           echo "ANSIBLE_FORCE_COLOR=1" >> $GITHUB_ENV
       - uses: actions/checkout@v4
       - name: Run molecule action
-        uses: arista-netdevops-community/action-molecule-avd@v1.7
+        uses: arista-netdevops-community/action-molecule-avd@v1.8.1
         with:
           molecule_parentdir: 'ansible_collections/arista/avd'
           molecule_command: 'test'
@@ -326,7 +326,7 @@ jobs:
           echo "ANSIBLE_FORCE_COLOR=1" >> $GITHUB_ENV
       - uses: actions/checkout@v4
       - name: Run molecule action
-        uses: arista-netdevops-community/action-molecule-avd@v1.7
+        uses: arista-netdevops-community/action-molecule-avd@v1.8.1
         with:
           molecule_parentdir: 'ansible_collections/arista/avd'
           molecule_command: 'test'

diff --git a/.gitignore b/.gitignore
@@ -8,14 +8,16 @@ __pycache__/
 *.pickle
 
 # pyavd ignores
-python-avd/build/
-python-avd/dist/
-python-avd/vendor/
-python-avd/tests/pyavd/artifacts/
-python-avd/pyavd.egg-info/
-python-avd/.tox/
-python-avd/.coverage
-python-avd/.mypy_cache/
+/python-avd/build/
+/python-avd/dist/
+/python-avd/vendor/
+/python-avd/tests/pyavd/artifacts/
+/python-avd/pyavd.egg-info/
+/python-avd/.tox/
+/python-avd/.coverage
+/python-avd/.mypy_cache/
+# Ignore cloned cloudvision-python repo created during generation of _cv/api
+/python-avd/pyavd/_cv/cloudvision-apis/
 
 # top level installers
 /*.tar.gz
@@ -30,9 +32,6 @@ python-avd/.mypy_cache/
 # ansible_collections/arista/avd/tests ignores
 ansible_collections/arista/avd/tests/.mypy_cache/
 
-# Ignore cloned cloudvision-python repo created during generation of cv_client/api
-ansible_collections/arista/avd/plugins/plugin_utils/cv_client/cloudvision-apis/
-
 # Development
 ## pyenv
 .python-version

diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -223,7 +223,7 @@ repos:
         language: python
         files: python-avd/pyavd/_eos_cli_config_gen/j2templates/
         pass_filenames: false
-        additional_dependencies: ['Jinja2>=3.0.0', 'cryptography>=38.0.4', 'deepmerge>=1.1.0', 'PyYAML>=6.0.0', 'pydantic>=2.3.0', 'jsonschema>=4.10.3', 'referencing>=0.35.0']
+        additional_dependencies: ['Jinja2>=3.0.0', 'cryptography>=38.0.4', 'deepmerge>=1.1.0', 'jsonschema>=4.10.3']
 
   - repo: https://github.com/igorshubovych/markdownlint-cli
     rev: v0.41.0

diff --git a/ansible_collections/arista/avd/CHANGELOG.rst b/ansible_collections/arista/avd/CHANGELOG.rst
@@ -4,6 +4,60 @@ Arista.Avd Release Notes
 
 .. contents:: Topics
 
+v4.10.0
+=======
+
+Release Summary
+---------------
+
+Release 4.10.0 - See documentation on avd.arista.com for details.
+
+Minor Changes
+-------------
+
+- Bump: Update version 4.10.0-dev0 by @carlbuchmann in https://github.com/aristanetworks/avd/pull/4184
+- Doc(eos_designs): Add warning about WAN BGP peer groups password by @gmuloc in https://github.com/aristanetworks/avd/pull/4265
+- Doc(eos_designs): Remove lookup plugin reference for Zscaler IE by @gmuloc in https://github.com/aristanetworks/avd/pull/4234
+- Doc(eos_designs): Replace wrong key referred in documentation `mlag_l3_peer_vlan` with `mlag_peer_l3_vlan` by @Vibhu-gslab in https://github.com/aristanetworks/avd/pull/4251
+- Doc(eos_designs): Update documentation to customize WAN flow tracking. by @gmuloc in https://github.com/aristanetworks/avd/pull/4253
+- Doc: AVD with Ansible Automation Platform Guide by @JulioPDX in https://github.com/aristanetworks/avd/pull/3910
+- Doc: Deprecate the eos_designs and eos_cli_config_gen jsonschema.json… by @gmuloc in https://github.com/aristanetworks/avd/pull/4195
+- Doc: Fix incorrect keys specified in default_mgmt_method by @carlbuchmann in https://github.com/aristanetworks/avd/pull/4206
+- Feat(cv_deploy): Add CV Pathfinder AVT hop count to metadata studio by @ClausHolbechArista in https://github.com/aristanetworks/avd/pull/4071
+- Feat(cv_deploy): Add application data to CV Pathfinder metadata by @ClausHolbechArista in https://github.com/aristanetworks/avd/pull/4247
+- Feat(eos_cli_config_gen): Add MPLS Tunnel Support for Traceroute and PMTU Discovery by @Shivani-gslab in https://github.com/aristanetworks/avd/pull/4219
+- Feat(eos_cli_config_gen): Add TLS options for radius_server by @nnbruce in https://github.com/aristanetworks/avd/pull/4194
+- Feat(eos_cli_config_gen): Add dscp support for application traffic recognition IPv4 by @gmuloc in https://github.com/aristanetworks/avd/pull/4241
+- Feat(eos_cli_config_gen): Add ptp profiles for ITU-T G8275 support by @colinmacgiolla in https://github.com/aristanetworks/avd/pull/4230
+- Feat(eos_cli_config_gen): Add support for tunnel-interface underlay vrf by @nathanmusser in https://github.com/aristanetworks/avd/pull/4211
+- Feat(eos_cli_config_gen): Add support to configure PEG DR election algorithm by @laxmikantchintakindi in https://github.com/aristanetworks/avd/pull/4095
+- Feat(eos_cli_config_gen): Enhance DHCP server data model (lease time, reservations, eos_cli) by @Shivani-gslab in https://github.com/aristanetworks/avd/pull/4252
+- Feat(eos_cli_config_gen): SyncE support by @colinmacgiolla in https://github.com/aristanetworks/avd/pull/4255
+- Feat(eos_designs): Add `ptp_settings` to replace `ptp` key in eos_designs by @laxmikantchintakindi in https://github.com/aristanetworks/avd/pull/4155
+- Feat(eos_designs): Add keys to set loopback0 and vtep_loopback directly by @gmuloc in https://github.com/aristanetworks/avd/pull/4168
+- Feat(eos_designs): Add option for ip igmp snooping fast-leave by @Shivani-gslab in https://github.com/aristanetworks/avd/pull/4180
+- Feat(eos_designs): Add support to add access-groups on l3-interfaces through network-services by @laxmikantchintakindi in https://github.com/aristanetworks/avd/pull/4163
+- Feat(eos_designs): Enhance custom IP addressing and descriptions for p2p-vrfs by @ClausHolbechArista in https://github.com/aristanetworks/avd/pull/4259
+- Feat(eos_designs): MLAG secondary should use short-esi from MLAG primary by @Vibhu-gslab in https://github.com/aristanetworks/avd/pull/4172
+- Feat(eos_designs): Underlay OSPF authentication by @jonxstill in https://github.com/aristanetworks/avd/pull/4169
+- Refactor(eos_cli_config_gen): Add primary key for connectivity monitor hosts by @gmuloc in https://github.com/aristanetworks/avd/pull/4264
+- Refactor(eos_designs,eos_cli_config_gen): Deprecate type conversion from dict-of-dicts to list-of-dicts by @ClausHolbechArista in https://github.com/aristanetworks/avd/pull/4237
+- Refactor(eos_validate_state): Add warning for ansible test mode by @gmuloc in https://github.com/aristanetworks/avd/pull/4173
+- Refactor(pyavd): Clean unused code requiring referencing library by @ClausHolbechArista in https://github.com/aristanetworks/avd/pull/4269
+- Refactor(pyavd): Suppress warnings for cryptography >=43.0.0 by @gmuloc in https://github.com/aristanetworks/avd/pull/4235
+
+Bugfixes
+--------
+
+- Fix(eos_cli_config_gen): Add a pseudo task to handle tags on import role by @gmuloc in https://github.com/aristanetworks/avd/pull/4258
+- Fix(eos_cli_config_gen): Fixing the wrong CLI generated for radius-server dynamic-authorizaton by @Shivani-gslab in https://github.com/aristanetworks/avd/pull/4224
+- Fix(eos_cli_config_gen): Restoring consistent schema validation behavior by @ClausHolbechArista in https://github.com/aristanetworks/avd/pull/4261
+- Fix(eos_validate_state): Sanitize markdown output on markdown validation report  by @nathanmusser in https://github.com/aristanetworks/avd/pull/4212
+- Fix(plugins): Fix deprecation warning after reformatting by @gmuloc in https://github.com/aristanetworks/avd/pull/4183
+- Fix(plugins): Prevent deprecation warnings when deprecated filters are not used by @gmuloc in https://github.com/aristanetworks/avd/pull/4199
+- Fix: Incorrect default value for 720XP for trident_forwarding_table_partition by @carlbuchmann in https://github.com/aristanetworks/avd/pull/4215
+- Fix: Typo in requirements.txt for PyAVD dev0 version by @ClausHolbechArista in https://github.com/aristanetworks/avd/pull/4248
+
 v4.9.0
 ======
 

diff --git a/ansible_collections/arista/avd/changelogs/.plugin-cache.yaml b/ansible_collections/arista/avd/changelogs/.plugin-cache.yaml
@@ -75,6 +75,11 @@ plugins:
   inventory: {}
   lookup: {}
   module:
+    _emit_warning:
+      description: Internal module - DO NOT USE - Emit a warning in a task.
+      name: _emit_warning
+      namespace: ''
+      version_added: 4.9.0
     batch_template:
       description: Render Jinja2 template on multiple items and write result to individual
         files.
@@ -160,4 +165,4 @@ plugins:
         than group_vars or host_vars
       name: global_vars
       version_added: 4.0.0
-version: 4.9.0
+version: 4.10.0
diff --git a/ansible_collections/arista/avd/changelogs/changelog.yaml b/ansible_collections/arista/avd/changelogs/changelog.yaml
@@ -1031,6 +1031,87 @@ releases:
     fragments:
     - v4.1.0.yml
     release_date: '2023-06-16'
+  4.10.0:
+    changes:
+      bugfixes:
+      - 'Fix(eos_cli_config_gen): Add a pseudo task to handle tags on import role
+        by @gmuloc in https://github.com/aristanetworks/avd/pull/4258'
+      - 'Fix(eos_cli_config_gen): Fixing the wrong CLI generated for radius-server
+        dynamic-authorizaton by @Shivani-gslab in https://github.com/aristanetworks/avd/pull/4224'
+      - 'Fix(eos_cli_config_gen): Restoring consistent schema validation behavior
+        by @ClausHolbechArista in https://github.com/aristanetworks/avd/pull/4261'
+      - 'Fix(eos_validate_state): Sanitize markdown output on markdown validation
+        report  by @nathanmusser in https://github.com/aristanetworks/avd/pull/4212'
+      - 'Fix(plugins): Fix deprecation warning after reformatting by @gmuloc in https://github.com/aristanetworks/avd/pull/4183'
+      - 'Fix(plugins): Prevent deprecation warnings when deprecated filters are not
+        used by @gmuloc in https://github.com/aristanetworks/avd/pull/4199'
+      - 'Fix: Incorrect default value for 720XP for trident_forwarding_table_partition
+        by @carlbuchmann in https://github.com/aristanetworks/avd/pull/4215'
+      - 'Fix: Typo in requirements.txt for PyAVD dev0 version by @ClausHolbechArista
+        in https://github.com/aristanetworks/avd/pull/4248'
+      minor_changes:
+      - 'Bump: Update version 4.10.0-dev0 by @carlbuchmann in https://github.com/aristanetworks/avd/pull/4184'
+      - 'Doc(eos_designs): Add warning about WAN BGP peer groups password by @gmuloc
+        in https://github.com/aristanetworks/avd/pull/4265'
+      - 'Doc(eos_designs): Remove lookup plugin reference for Zscaler IE by @gmuloc
+        in https://github.com/aristanetworks/avd/pull/4234'
+      - 'Doc(eos_designs): Replace wrong key referred in documentation `mlag_l3_peer_vlan`
+        with `mlag_peer_l3_vlan` by @Vibhu-gslab in https://github.com/aristanetworks/avd/pull/4251'
+      - 'Doc(eos_designs): Update documentation to customize WAN flow tracking. by
+        @gmuloc in https://github.com/aristanetworks/avd/pull/4253'
+      - 'Doc: AVD with Ansible Automation Platform Guide by @JulioPDX in https://github.com/aristanetworks/avd/pull/3910'
+      - "Doc: Deprecate the eos_designs and eos_cli_config_gen jsonschema.json\u2026
+        by @gmuloc in https://github.com/aristanetworks/avd/pull/4195"
+      - 'Doc: Fix incorrect keys specified in default_mgmt_method by @carlbuchmann
+        in https://github.com/aristanetworks/avd/pull/4206'
+      - 'Feat(cv_deploy): Add CV Pathfinder AVT hop count to metadata studio by @ClausHolbechArista
+        in https://github.com/aristanetworks/avd/pull/4071'
+      - 'Feat(cv_deploy): Add application data to CV Pathfinder metadata by @ClausHolbechArista
+        in https://github.com/aristanetworks/avd/pull/4247'
+      - 'Feat(eos_cli_config_gen): Add MPLS Tunnel Support for Traceroute and PMTU
+        Discovery by @Shivani-gslab in https://github.com/aristanetworks/avd/pull/4219'
+      - 'Feat(eos_cli_config_gen): Add TLS options for radius_server by @nnbruce in
+        https://github.com/aristanetworks/avd/pull/4194'
+      - 'Feat(eos_cli_config_gen): Add dscp support for application traffic recognition
+        IPv4 by @gmuloc in https://github.com/aristanetworks/avd/pull/4241'
+      - 'Feat(eos_cli_config_gen): Add ptp profiles for ITU-T G8275 support by @colinmacgiolla
+        in https://github.com/aristanetworks/avd/pull/4230'
+      - 'Feat(eos_cli_config_gen): Add support for tunnel-interface underlay vrf by
+        @nathanmusser in https://github.com/aristanetworks/avd/pull/4211'
+      - 'Feat(eos_cli_config_gen): Add support to configure PEG DR election algorithm
+        by @laxmikantchintakindi in https://github.com/aristanetworks/avd/pull/4095'
+      - 'Feat(eos_cli_config_gen): Enhance DHCP server data model (lease time, reservations,
+        eos_cli) by @Shivani-gslab in https://github.com/aristanetworks/avd/pull/4252'
+      - 'Feat(eos_cli_config_gen): SyncE support by @colinmacgiolla in https://github.com/aristanetworks/avd/pull/4255'
+      - 'Feat(eos_designs): Add `ptp_settings` to replace `ptp` key in eos_designs
+        by @laxmikantchintakindi in https://github.com/aristanetworks/avd/pull/4155'
+      - 'Feat(eos_designs): Add keys to set loopback0 and vtep_loopback directly by
+        @gmuloc in https://github.com/aristanetworks/avd/pull/4168'
+      - 'Feat(eos_designs): Add option for ip igmp snooping fast-leave by @Shivani-gslab
+        in https://github.com/aristanetworks/avd/pull/4180'
+      - 'Feat(eos_designs): Add support to add access-groups on l3-interfaces through
+        network-services by @laxmikantchintakindi in https://github.com/aristanetworks/avd/pull/4163'
+      - 'Feat(eos_designs): Enhance custom IP addressing and descriptions for p2p-vrfs
+        by @ClausHolbechArista in https://github.com/aristanetworks/avd/pull/4259'
+      - 'Feat(eos_designs): MLAG secondary should use short-esi from MLAG primary
+        by @Vibhu-gslab in https://github.com/aristanetworks/avd/pull/4172'
+      - 'Feat(eos_designs): Underlay OSPF authentication by @jonxstill in https://github.com/aristanetworks/avd/pull/4169'
+      - 'Refactor(eos_cli_config_gen): Add primary key for connectivity monitor hosts
+        by @gmuloc in https://github.com/aristanetworks/avd/pull/4264'
+      - 'Refactor(eos_designs,eos_cli_config_gen): Deprecate type conversion from
+        dict-of-dicts to list-of-dicts by @ClausHolbechArista in https://github.com/aristanetworks/avd/pull/4237'
+      - 'Refactor(eos_validate_state): Add warning for ansible test mode by @gmuloc
+        in https://github.com/aristanetworks/avd/pull/4173'
+      - 'Refactor(pyavd): Clean unused code requiring referencing library by @ClausHolbechArista
+        in https://github.com/aristanetworks/avd/pull/4269'
+      - 'Refactor(pyavd): Suppress warnings for cryptography >=43.0.0 by @gmuloc in
+        https://github.com/aristanetworks/avd/pull/4235'
+      release_summary: 'Release 4.10.0 - See documentation on avd.arista.com for details.
+
+        '
+    fragments:
+    - v4.10.0.yml
+    release_date: '2024-07-26'
   4.2.0:
     changes:
       bugfixes: