Fix(eos_designs)!: VARPv6 config is not generated even when "ipv6_ena…

…ble: true" is specified (#4208)

ansible_collections/arista/avd/docs/release-notes/5.x.x.md

@@ -80,6 +80,21 @@ for details.
 
 TODO: add level4 sections for breaking changes outlining the change and referring to porting guide for migration.
 
+#### ipv6_virtual_router_addresses are now configured if ipv6_enable is true on SVIs
+
+For SVIs with `ipv6_virtual_router_addresses` set, AVD versions below 5.0.0 only rendered the configuration if `ipv6_address`
+was also set on the SVI.
+
+With AVD version 5.0.0 `ipv6_virtual_router_addresses` are rendered in the configuration if either `ipv6_address` or `ipv6_enable: true` is set.
+
+#### ipv6_address_virtuals are now only configured on SVIs if ipv6_virtual_router_addresses are not set
+
+AVD versions below 5.0.0 had a bug where `ipv6_address_virtuals` were rendered in the configuration even if `ipv6_virtual_router_addresses` were
+set. Instead `ipv6_address_virtuals` were removed if the IPv4 `ip_virtual_router_addresses` were set.
+
+With AVD version 5.0.0 `ipv6_address_virtuals` are only rendered in the configuration when `ipv6_virtual_router_addresses` are not set for a specific node.
+`ip_virtual_router_addresses` is no longer used to decide whether `ipv6_address_virtuals` are configured.
+
 #### Removal of schema in JSON format
 
 The `eos_designs.jsonschema.json` is no longer generated. This schema was not being used and had never been complete.

ansible_collections/arista/avd/molecule/eos_designs_unit_tests/intended/configs/varpv6.cfg

@@ -0,0 +1,163 @@
+!RANCID-CONTENT-TYPE: arista
+!
+vlan internal order ascending range 1006 1199
+!
+transceiver qsfp default-mode 4x10G
+!
+service routing protocols model multi-agent
+!
+hostname varpv6
+!
+no enable password
+no aaa root
+!
+vlan 100
+   name VARPv6_configured_1
+!
+vlan 200
+   name VARPv6_not_configured_1
+!
+vlan 300
+   name VARPv6_configured_2
+!
+vlan 400
+   name VARPv6_not_configured_2
+!
+vlan 500
+   name VARPv6_not_configured_3
+!
+vrf instance MGMT
+!
+vrf instance VRF1
+!
+interface Loopback0
+   description EVPN_Overlay_Peering
+   no shutdown
+   ip address 192.168.255.101/32
+!
+interface Loopback1
+   description VTEP_VXLAN_Tunnel_Source
+   no shutdown
+   ip address 192.168.254.101/32
+!
+interface Vlan100
+   description VARPv6_configured_1
+   no shutdown
+   vrf VRF1
+   ipv6 address 2001:db8::2/64
+   ipv6 virtual-router address fe80::1
+!
+interface Vlan200
+   description VARPv6_not_configured_1
+   no shutdown
+   vrf VRF1
+!
+interface Vlan300
+   description VARPv6_configured_2
+   no shutdown
+   vrf VRF1
+   ipv6 enable
+   ipv6 virtual-router address fe80::1
+!
+interface Vlan400
+   description VARPv6_not_configured_2
+   no shutdown
+   vrf VRF1
+!
+interface Vlan500
+   description VARPv6_not_configured_3
+   no shutdown
+   vrf VRF1
+   ipv6 address virtual 2001:db8::1/64
+!
+interface Vxlan1
+   description varpv6_VTEP
+   vxlan source-interface Loopback1
+   vxlan udp-port 4789
+   vxlan vlan 100 vni 10100
+   vxlan vlan 200 vni 10200
+   vxlan vlan 300 vni 10300
+   vxlan vlan 400 vni 10400
+   vxlan vlan 500 vni 10500
+   vxlan vrf VRF1 vni 1
+!
+ip virtual-router mac-address 00:dc:00:00:00:0a
+!
+ip routing
+no ip routing vrf MGMT
+ip routing vrf VRF1
+ipv6 unicast-routing vrf VRF1
+!
+ip prefix-list PL-LOOPBACKS-EVPN-OVERLAY
+   seq 10 permit 192.168.255.0/24 eq 32
+   seq 20 permit 192.168.254.0/24 eq 32
+!
+route-map RM-CONN-2-BGP permit 10
+   match ip address prefix-list PL-LOOPBACKS-EVPN-OVERLAY
+!
+router bfd
+   multihop interval 300 min-rx 300 multiplier 3
+!
+router bgp 101
+   router-id 192.168.255.101
+   maximum-paths 4 ecmp 4
+   update wait-install
+   no bgp default ipv4-unicast
+   neighbor EVPN-OVERLAY-PEERS peer group
+   neighbor EVPN-OVERLAY-PEERS update-source Loopback0
+   neighbor EVPN-OVERLAY-PEERS bfd
+   neighbor EVPN-OVERLAY-PEERS ebgp-multihop 3
+   neighbor EVPN-OVERLAY-PEERS send-community
+   neighbor EVPN-OVERLAY-PEERS maximum-routes 0
+   neighbor IPv4-UNDERLAY-PEERS peer group
+   neighbor IPv4-UNDERLAY-PEERS send-community
+   neighbor IPv4-UNDERLAY-PEERS maximum-routes 12000
+   redistribute connected route-map RM-CONN-2-BGP
+   !
+   vlan 100
+      rd 192.168.255.101:10100
+      route-target both 10100:10100
+      redistribute learned
+   !
+   vlan 200
+      rd 192.168.255.101:10200
+      route-target both 10200:10200
+      redistribute learned
+   !
+   vlan 300
+      rd 192.168.255.101:10300
+      route-target both 10300:10300
+      redistribute learned
+   !
+   vlan 400
+      rd 192.168.255.101:10400
+      route-target both 10400:10400
+      redistribute learned
+   !
+   vlan 500
+      rd 192.168.255.101:10500
+      route-target both 10500:10500
+      redistribute learned
+   !
+   address-family evpn
+      neighbor EVPN-OVERLAY-PEERS activate
+   !
+   address-family ipv4
+      no neighbor EVPN-OVERLAY-PEERS activate
+      neighbor IPv4-UNDERLAY-PEERS activate
+   !
+   vrf VRF1
+      rd 192.168.255.101:1
+      route-target import evpn 1:1
+      route-target export evpn 1:1
+      router-id 192.168.255.101
+      redistribute connected
+!
+management api http-commands
+   protocol https
+   no shutdown
+   !
+   vrf MGMT
+      no shutdown
+!
+end