Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor eos_cli_config_gen switchport data models #2288

Closed
ClausHolbechArista opened this issue Nov 22, 2022 · 3 comments · Fixed by #4158
Closed

Refactor eos_cli_config_gen switchport data models #2288

ClausHolbechArista opened this issue Nov 22, 2022 · 3 comments · Fixed by #4158
Assignees
Milestone

Comments

@ClausHolbechArista
Copy link
Contributor

ClausHolbechArista commented Nov 22, 2022

ethernet_interfaces(and probably others):

  • All/most switchport xxx commands are cut off like native_vlan and vlans which should have been switchport.trunk.native_vlan and switchport.access.vlan & switchport.trunk.allowed_vlans.
  • We have a type key which is abstracting too much in the config
@ClausHolbechArista ClausHolbechArista modified the milestones: v4.0.0-rc1, v3.8.0 Nov 22, 2022
@ClausHolbechArista ClausHolbechArista changed the title Refactor snmp_server data models Refactor data models for avd 4.0 Nov 28, 2022
@github-actions
Copy link

This issue is stale because it has been open 90 days with no activity. The issue will be reviewed by a maintainer and may be closed

Copy link

This issue is stale because it has been open 90 days with no activity. The issue will be reviewed by a maintainer and may be closed

@ClausHolbechArista
Copy link
Contributor Author

ClausHolbechArista commented Jun 3, 2024

This should be implemented in eos_cli_config_gen immediately. It should support the full switchport syntax, and should not be combined with the existing mode, vlans, native_vlan, type and maybe other keys.
Once implemented, we can switch the output of eos_designs in 5.0 and deprecate the old keys.

Since type also affects subinterfaces etc, we may have to add a couple of other models before we can remove mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants