-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_designs): Add cv_settings to replace cvp_* and terminattr_* #3301
base: devel
Are you sure you want to change the base?
Feat(eos_designs): Add cv_settings to replace cvp_* and terminattr_* #3301
Conversation
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
I think we want to add So data model would be:
|
|
||
if vrf == "use_inband_mgmt_vrf": | ||
if self.shared_utils.inband_mgmt_interface is None: | ||
raise AristaAvdError("'ntp_settings.server_vrf' is set to 'use_inband_mgmt_vrf' but this node is missing configuration for inband management") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe ntp_settings.server_vrf
should be {org_var}
This PR is stale because it has been open 30 days with no activity. The PR will be reviewed by a maintainer and may be closed |
This PR is stale because it has been open 30 days with no activity. The PR will be reviewed by a maintainer and may be closed |
Change Summary
Add cv_settings to replace cvp_* and terminattr_*
Component(s) name
arista.avd.eos_designs
Proposed changes
Settings for configuring CloudVision telemetry streaming and provisioning.
cv_settings
replaces the following deprecated keys, which are ignored whencv_settings
is set:cvp_ingestauth_key
cvp_instance_ip
cvp_instance_ips
cvp_token_file
terminattr_disable_aaa
terminattr_ingestexclude
terminattr_ingestgrpcurl_port
terminattr_smashexcludes
New data model:
How to test
eos_designs_deprecated_vars
cv_settings
utilizing all options.Checklist
User Checklist
Repository Checklist