Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_designs): Add cv_settings to replace cvp_* and terminattr_* #3301

Draft
wants to merge 3 commits into
base: devel
Choose a base branch
from

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Add cv_settings to replace cvp_* and terminattr_*

Component(s) name

arista.avd.eos_designs

Proposed changes

Settings for configuring CloudVision telemetry streaming and provisioning.

cv_settings replaces the following deprecated keys, which are ignored when cv_settings is set:

  • cvp_ingestauth_key
  • cvp_instance_ip
  • cvp_instance_ips
  • cvp_token_file
  • terminattr_disable_aaa
  • terminattr_ingestexclude
  • terminattr_ingestgrpcurl_port
  • terminattr_smashexcludes

New data model:

cv_settings:
  cvaas_clusters:
    - name: <str>
      server: <str>
      vrf: <str>
      token_file: <str>
  onprem_clusters:
    - name: <str>
      servers:
        - name: <str>
          port: <int>
      vrf: <str>
      key: <str>
      token_file: <str>
  terminattr_ingestexclude: <str>
  terminattr_smashexcludes: <str>
  terminattr_disable_aaa: <bool>

How to test

  • Updated all existing molecule scenarios and examples to use the new data model
  • Added the deprecated vars to eos_designs_deprecated_vars
  • Added new unit test for cv_settings utilizing all options.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Oct 27, 2023
@ClausHolbechArista ClausHolbechArista marked this pull request as draft November 8, 2023 12:14
@github-actions github-actions bot added the state: conflict PR with conflict label Nov 11, 2023
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@jrecchia1029
Copy link
Contributor

I think we want to add source_interface to the data model to be even more deterministic than vrf in inband scenarios.

So data model would be:

cv_settings:
  cvaas_clusters:
    - name: <str>
      server: <str>
      vrf: <str>
      source_interface: <str>
      token_file: <str>
  onprem_clusters:
    - name: <str>
      servers:
        - name: <str>
          port: <int>
      vrf: <str>
      source_interface: <str>
      key: <str>
      token_file: <str>
  terminattr_ingestexclude: <str>
  terminattr_smashexcludes: <str>
  terminattr_disable_aaa: <bool>


if vrf == "use_inband_mgmt_vrf":
if self.shared_utils.inband_mgmt_interface is None:
raise AristaAvdError("'ntp_settings.server_vrf' is set to 'use_inband_mgmt_vrf' but this node is missing configuration for inband management")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe ntp_settings.server_vrf should be {org_var}

Copy link

This PR is stale because it has been open 30 days with no activity. The PR will be reviewed by a maintainer and may be closed

Copy link

This PR is stale because it has been open 30 days with no activity. The PR will be reviewed by a maintainer and may be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants