Doc: Contribution Guide Updates #3766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: documentation
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
pmprado
reviewed
May 24, 2024
pmprado
reviewed
May 24, 2024
carlbuchmann
force-pushed
the
doc-contribution-guide-improvements
branch
from
bef9f56
to
78c086f
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
github-actions
bot
added
the
state: CI Updated
github-actions
bot
added
type: dependencies
ansible_collections/arista/avd/docs/contribution/development-tooling.md
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/docs/contribution/development-tooling.md
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/docs/contribution/development-tooling.md
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/docs/contribution/development-tooling.md
Outdated
Show resolved
Hide resolved
3 tasks
ansible_collections/arista/avd/docs/contribution/development-tooling.md
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/docs/contribution/development-tooling.md
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/docs/contribution/development-tooling.md
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/docs/contribution/development-tooling.md
Outdated
Show resolved
Hide resolved
…ooling.md Co-authored-by: Alexey Gorbunov <[email protected]>
Co-authored-by: Alexey Gorbunov <[email protected]>
Makefile
Outdated
| @@ -44,24 +44,24 @@ pyavd-editable-install: ## Build and install PyAVD as editable | |||
| ######################################### | |||
|
|
|||
| .PHONY: sanity | |||
| sanity: sanity-info sanity-lint sanity-import ## Run ansible-test sanity validation. | |||
| sanity: sanity-info sanity-lint sanity-import ## Run ansible-test sanity validation. Requires docker. | |||
There was a problem hiding this comment.
Is this still correct? Since you changed the default to venv.
There was a problem hiding this comment.
this target runs all 3 targets sanity-info sanity-lint sanity-import and sanity-info requires docker. I will also update this and the document and makefile.
There was a problem hiding this comment.
nvm this comment, need more coffee this morning you are correct that we no longer require docker to run this!
There was a problem hiding this comment.
resolved with 69afeed
ansible_collections/arista/avd/docs/installation/collection-installation.md
Outdated
Show resolved
Hide resolved
…stallation.md Co-authored-by: Claus Holbech <[email protected]>
|
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Makefile:pre-commit-config.yml.Remove unused/legacy content
Task List
Note: The Dev Container doesn't support running any test that requires docker, tracked in issue #4052