-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(eos_designs): Fix code error for monitor_sessions for network_ports #3818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
state: CI Updated
CI scenario have been updated in the PR
role: eos_designs
issue related to eos_designs role
labels
Apr 5, 2024
carlbuchmann
approved these changes
Apr 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ClausHolbechArista
previously approved these changes
Apr 8, 2024
gmuloc
dismissed
ClausHolbechArista’s stale review
April 8, 2024 09:18
dismissing review to prevent merge before new implementaiton
bjmeuer
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ClausHolbechArista
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
rn: Fix(eos_designs)
role: eos_designs
issue related to eos_designs role
state: CI Updated
CI scenario have been updated in the PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Fix wrong python object access for network_ports.
no molecule test existed for this so it never worked probably or has not been for a while
Related Issue(s)
Fixes #3816
Component(s) name
arista.avd.eos_designs
Proposed changes
Fix python typo
How to test
molecule
Checklist
User Checklist
Repository Checklist