Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(eos_designs): Fix code error for monitor_sessions for network_ports #3818

Merged
merged 6 commits into from
Apr 9, 2024

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Apr 5, 2024

Change Summary

Fix wrong python object access for network_ports.
no molecule test existed for this so it never worked probably or has not been for a while

Related Issue(s)

Fixes #3816

Component(s) name

arista.avd.eos_designs

Proposed changes

Fix python typo

How to test

molecule

Checklist

User Checklist

  • Need reviewer to check the port-channel output, it looks redundant.

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners April 5, 2024 22:14
@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR role: eos_designs issue related to eos_designs role labels Apr 5, 2024
@gmuloc gmuloc requested a review from marcusmcpeek April 5, 2024 22:14
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmuloc gmuloc dismissed ClausHolbechArista’s stale review April 8, 2024 09:18

dismissing review to prevent merge before new implementaiton

Copy link
Contributor

@bjmeuer bjmeuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann marked this pull request as draft April 8, 2024 15:15
@carlbuchmann carlbuchmann self-requested a review April 8, 2024 15:17
@gmuloc gmuloc marked this pull request as ready for review April 9, 2024 09:24
@ClausHolbechArista ClausHolbechArista merged commit 79e7462 into aristanetworks:devel Apr 9, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Fix(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix(eos_designs): monitor_sessions not supported in network_ports
4 participants