-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Option to set RCF route bgp address-family vpn-ipv6/ipv4 and redistribute. #3819
Feat(eos_cli_config_gen): Option to set RCF route bgp address-family vpn-ipv6/ipv4 and redistribute. #3819
Conversation
3efd920
to
a0c9748
Compare
...llections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_bgp.schema.yml
Outdated
Show resolved
Hide resolved
...llections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_bgp.schema.yml
Outdated
Show resolved
Hide resolved
…vpn-ipv6/ipv4 and redistribute
a0c9748
to
4fc34a6
Compare
cec28bf
to
511cbe3
Compare
511cbe3
to
5e6dcfc
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/router-bgp.md
Outdated
Show resolved
Hide resolved
f149d64
to
0160c18
Compare
11ce9fb
to
d3fc43f
Compare
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/router-bgp.md
Outdated
Show resolved
Hide resolved
6af7272
to
a27c19f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have one comment but i dont think that we can fix it now. Tested on lab LGTM
@@ -91,7 +91,9 @@ router bgp 65101 | |||
aggregate-address 1.12.1.0/24 as-set advertise-map ADV-MAP supress-map SUP-MAP summary-only attribute-map RM-ATTRIBUTE match-map RM-MATCH advertise-only | |||
aggregate-address 2.2.1.0/24 | |||
redistribute bgp leaked route-map RM-REDISTRIBUTE-BGP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This bgp leaked config reflects at the end. Need to check. Output generated from AVD
redistribute bgp leaked route-map RM-REDISTRIBUTE-BGP
redistribute connected route-map RM-CONN-2-BGP
redistribute dynamic route-map Route_map_dynamic
redistribute ospf include leaked
redistribute static rcf Router_BGP_Static()
output from EOS
redistribute connected route-map RM-CONN-2-BGP
redistribute ospf include leaked
redistribute static rcf Router_BGP_Static()
redistribute dynamic route-map Route_map_dynamic
redistribute bgp leaked route-map RM-REDISTRIBUTE-BGP
Seems like EOS is ordering the protocol randomly in config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on EOS CLI.
LGTM!
Change Summary
Adding RCF for router-bgp address-family vpn-ipv4, vpn-ipv6 and route redistribute.
Related Issue(s)
part of #2397
Component(s) name
arista.avd.eos_cli_config_gen
Checklist
Repository Checklist