Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Option to set RCF route bgp address-family vpn-ipv6/ipv4 and redistribute. #3819

Conversation

Vibhu-gslab
Copy link
Contributor

Change Summary

Adding RCF for router-bgp address-family vpn-ipv4, vpn-ipv6 and route redistribute.

Related Issue(s)

part of #2397

Component(s) name

arista.avd.eos_cli_config_gen

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Apr 6, 2024
@Vibhu-gslab Vibhu-gslab force-pushed the route_bgp_redistribute_vpn_ipv4_ipv6 branch 3 times, most recently from 3efd920 to a0c9748 Compare April 8, 2024 10:51
@Vibhu-gslab Vibhu-gslab force-pushed the route_bgp_redistribute_vpn_ipv4_ipv6 branch from a0c9748 to 4fc34a6 Compare April 15, 2024 12:14
@github-actions github-actions bot added the role: eos_designs issue related to eos_designs role label Apr 15, 2024
@Vibhu-gslab Vibhu-gslab force-pushed the route_bgp_redistribute_vpn_ipv4_ipv6 branch from cec28bf to 511cbe3 Compare April 16, 2024 10:28
@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review April 16, 2024 10:28
@Vibhu-gslab Vibhu-gslab requested review from a team as code owners April 16, 2024 10:28
@Vibhu-gslab Vibhu-gslab force-pushed the route_bgp_redistribute_vpn_ipv4_ipv6 branch from 511cbe3 to 5e6dcfc Compare April 17, 2024 12:07
@github-actions github-actions bot added the state: conflict PR with conflict label Apr 17, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label Apr 18, 2024
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot added the type: documentation Improvements or additions to documentation label Apr 22, 2024
@Vibhu-gslab Vibhu-gslab marked this pull request as draft April 22, 2024 13:11
@Vibhu-gslab Vibhu-gslab force-pushed the route_bgp_redistribute_vpn_ipv4_ipv6 branch from f149d64 to 0160c18 Compare April 22, 2024 13:30
@github-actions github-actions bot removed the type: documentation Improvements or additions to documentation label Apr 22, 2024
@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review April 22, 2024 14:30
@Vibhu-gslab Vibhu-gslab marked this pull request as draft April 23, 2024 04:19
@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review April 23, 2024 04:58
@Vibhu-gslab Vibhu-gslab marked this pull request as draft April 23, 2024 07:54
@Vibhu-gslab Vibhu-gslab force-pushed the route_bgp_redistribute_vpn_ipv4_ipv6 branch from 11ce9fb to d3fc43f Compare April 25, 2024 04:08
@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review April 25, 2024 04:09
@Vibhu-gslab Vibhu-gslab marked this pull request as draft May 2, 2024 05:08
@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review May 2, 2024 10:22
@Vibhu-gslab Vibhu-gslab marked this pull request as draft May 2, 2024 13:07
@Vibhu-gslab Vibhu-gslab force-pushed the route_bgp_redistribute_vpn_ipv4_ipv6 branch from 6af7272 to a27c19f Compare May 7, 2024 13:37
Copy link
Contributor

@MaheshGSLAB MaheshGSLAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have one comment but i dont think that we can fix it now. Tested on lab LGTM

@@ -91,7 +91,9 @@ router bgp 65101
aggregate-address 1.12.1.0/24 as-set advertise-map ADV-MAP supress-map SUP-MAP summary-only attribute-map RM-ATTRIBUTE match-map RM-MATCH advertise-only
aggregate-address 2.2.1.0/24
redistribute bgp leaked route-map RM-REDISTRIBUTE-BGP
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bgp leaked config reflects at the end. Need to check. Output generated from AVD

   redistribute bgp leaked route-map RM-REDISTRIBUTE-BGP
   redistribute connected route-map RM-CONN-2-BGP
   redistribute dynamic route-map Route_map_dynamic
   redistribute ospf include leaked
   redistribute static rcf Router_BGP_Static()

output from EOS

   redistribute connected route-map RM-CONN-2-BGP
   redistribute ospf include leaked
   redistribute static rcf Router_BGP_Static()
   redistribute dynamic route-map Route_map_dynamic
   redistribute bgp leaked route-map RM-REDISTRIBUTE-BGP

Seems like EOS is ordering the protocol randomly in config.

Copy link
Contributor

@Shivani-gslab Shivani-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on EOS CLI.
LGTM!

@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review May 8, 2024 09:16
@ClausHolbechArista ClausHolbechArista merged commit 9783b76 into aristanetworks:devel May 8, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants