Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(pyavd): Remove accidental requirement for PyYAML #3838

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Remove accidental requirement for PyYAML

Related Issue(s)

Fixes #3834

Component(s) name

PyAVD

Proposed changes

PyAVD vendors in code from ansible-avd, including all utilities, even if they are not being used in PyAVD.
This resulted in getting some YAML related utils into PyAVD, which in turn leads to failures when PyYAML is not installed.

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmuloc gmuloc merged commit d0551d9 into aristanetworks:devel Apr 11, 2024
36 checks passed
carlbuchmann pushed a commit to carlbuchmann/avd that referenced this pull request Apr 12, 2024
ClausHolbechArista added a commit that referenced this pull request Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pyAVD failing due to dependency on pyyaml
3 participants