Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Add support for BGP TCP AO. #3853

Merged
merged 51 commits into from
May 22, 2024
Merged

Feat(eos_cli_config_gen): Add support for BGP TCP AO. #3853

merged 51 commits into from
May 22, 2024

Conversation

laxmikantchintakindi
Copy link
Contributor

@laxmikantchintakindi laxmikantchintakindi commented Apr 15, 2024 •
edited
Loading

Change Summary

Add support for BGP TCP authentication.

Related Issue(s)

Fixes #3699

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Added schema for security profile under management security. Updated templates too.
Updated router-bgp schema and templates.

How to test

Checklist

User Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Apr 15, 2024
@laxmikantchintakindi laxmikantchintakindi marked this pull request as ready for review April 16, 2024 07:28
@laxmikantchintakindi laxmikantchintakindi marked this pull request as draft April 16, 2024 07:39
@gmuloc
Copy link
Contributor

gmuloc commented Apr 17, 2024

@dgonzalez85 can you please test this as you have opened the issue?
Thanks!

@laxmikantchintakindi laxmikantchintakindi marked this pull request as ready for review April 24, 2024 13:35
ClausHolbechArista
ClausHolbechArista requested changes Apr 29, 2024
View reviewed changes
...llections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_bgp.schema.yml Outdated Show resolved Hide resolved
...llections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_bgp.schema.yml Outdated Show resolved Hide resolved
.../arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/management_security.schema.yml Outdated Show resolved Hide resolved
.../arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/management_security.schema.yml Outdated Show resolved Hide resolved
...llections/arista/avd/roles/eos_cli_config_gen/templates/documentation/management-security.j2 Outdated Show resolved Hide resolved
...llections/arista/avd/roles/eos_cli_config_gen/templates/documentation/management-security.j2 Outdated Show resolved Hide resolved
...llections/arista/avd/roles/eos_cli_config_gen/templates/documentation/management-security.j2 Outdated Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/management-security.j2 Outdated Show resolved Hide resolved
...llections/arista/avd/roles/eos_cli_config_gen/templates/documentation/management-security.j2 Outdated Show resolved Hide resolved
@ClausHolbechArista ClausHolbechArista marked this pull request as draft April 29, 2024 08:38
@laxmikantchintakindi laxmikantchintakindi marked this pull request as ready for review May 2, 2024 11:46
@laxmikantchintakindi laxmikantchintakindi marked this pull request as draft May 3, 2024 05:28
@laxmikantchintakindi laxmikantchintakindi marked this pull request as draft May 15, 2024 09:55
@laxmikantchintakindi laxmikantchintakindi marked this pull request as ready for review May 15, 2024 10:14
@laxmikantchintakindi laxmikantchintakindi marked this pull request as draft May 16, 2024 09:22
@laxmikantchintakindi @MaheshGSLAB
Update ansible_collections/arista/avd/roles/eos_cli_config_gen/templa…
432c3a8 
…tes/eos/management-security.j2

Co-authored-by: Mahesh Kumar <[email protected]>
@laxmikantchintakindi laxmikantchintakindi marked this pull request as ready for review May 17, 2024 08:33
@laxmikantchintakindi laxmikantchintakindi marked this pull request as draft May 17, 2024 08:34
@laxmikantchintakindi laxmikantchintakindi marked this pull request as ready for review May 17, 2024 09:59
ClausHolbechArista
ClausHolbechArista requested changes May 21, 2024
View reviewed changes
...lections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/management-security.md Outdated Show resolved Hide resolved
..._collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/management-security.cfg Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/management-security.j2 Outdated Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/management-security.j2 Outdated Show resolved Hide resolved
...llections/arista/avd/roles/eos_cli_config_gen/templates/documentation/management-security.j2 Outdated Show resolved Hide resolved
...llections/arista/avd/roles/eos_cli_config_gen/templates/documentation/management-security.j2 Outdated Show resolved Hide resolved
...llections/arista/avd/roles/eos_cli_config_gen/templates/documentation/management-security.j2 Outdated Show resolved Hide resolved
@laxmikantchintakindi laxmikantchintakindi marked this pull request as draft May 21, 2024 06:23
@laxmikantchintakindi laxmikantchintakindi marked this pull request as ready for review May 21, 2024 07:26
@ClausHolbechArista ClausHolbechArista merged commit 611110c into aristanetworks:devel May 22, 2024
43 checks passed
@laxmikantchintakindi laxmikantchintakindi deleted the bgptcpao branch May 22, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@Vibhu-gslab Vibhu-gslab Vibhu-gslab approved these changes

@MaheshGSLAB MaheshGSLAB MaheshGSLAB approved these changes

@Shivani-gslab Shivani-gslab Awaiting requested review from Shivani-gslab

Assignees

@laxmikantchintakindi laxmikantchintakindi

Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat(eos_cli_config_gen): Add support for BGP TCP AO
6 participants
@laxmikantchintakindi @gmuloc @ClausHolbechArista @Vibhu-gslab @MaheshGSLAB @Shivani-gslab