Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(eos_validate_state): ANTA Remove the use of the eos_design's "type" variable #3870

Merged
merged 7 commits into from
Apr 24, 2024

Conversation

carl-baillargeon
Copy link
Contributor

Change Summary

Remove the use of type: l3leaf when testing. This is an eos_designs variable that can be customized and we cannot rely on this. Custom node types with VTEP role will now be tested properly.

Related Issue(s)

Fixes #1047

Component(s) name

arista.avd.eos_designs ANTA Mode

Proposed changes

  • Added a method is_vtep to determine if a host is a VTEP or not based on the presence of a VXLAN interface.

How to test

  • Create a custom node type in eos_designs, rebuild your configs, run eos_validate_state in ANTA mode (see below) and make sure tests are added properly to the catalog of your custom nodes.
  • ansible-playbook playbooks/fabric-validate.yml -e use_anta=true -e save_catalog=true

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added the state: conflict PR with conflict label Apr 18, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmuloc gmuloc requested review from a team April 19, 2024 13:17
@MaheshGSLAB MaheshGSLAB requested a review from a team April 23, 2024 10:59
@gmuloc gmuloc merged commit f9dc4a0 into aristanetworks:devel Apr 24, 2024
37 checks passed
@carl-baillargeon carl-baillargeon deleted the fix/issue-1047 branch May 18, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eos_validate_state should not rely on eos_designs variable type
3 participants