-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(eos_validate_state): ANTA Remove the use of the eos_design's "type" variable #3870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
role: eos_validate_state
state: CI Updated
CI scenario have been updated in the PR
labels
Apr 17, 2024
gmuloc
reviewed
Apr 17, 2024
ansible_collections/arista/avd/plugins/plugin_utils/eos_validate_state_utils/mixins.py
Outdated
Show resolved
Hide resolved
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
carl-baillargeon
force-pushed
the
fix/issue-1047
branch
from
April 18, 2024 12:24
6712024
to
8e383f9
Compare
Conflicts have been resolved. A maintainer will review the pull request shortly. |
gmuloc
reviewed
Apr 19, 2024
..._collections/arista/avd/roles/eos_validate_state/python_modules/tests/avdtestconnectivity.py
Outdated
Show resolved
Hide resolved
gmuloc
reviewed
Apr 19, 2024
ansible_collections/arista/avd/roles/eos_validate_state/python_modules/tests/avdtestrouting.py
Outdated
Show resolved
Hide resolved
gmuloc
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
MaheshGSLAB
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
EPIC - eos_validate_state ANTA
rn: Fix(eos_validate_state)
role: eos_validate_state
state: CI Updated
CI scenario have been updated in the PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Remove the use of
type: l3leaf
when testing. This is an eos_designs variable that can be customized and we cannot rely on this. Custom node types with VTEP role will now be tested properly.Related Issue(s)
Fixes #1047
Component(s) name
arista.avd.eos_designs
ANTA ModeProposed changes
is_vtep
to determine if a host is a VTEP or not based on the presence of a VXLAN interface.How to test
ansible-playbook playbooks/fabric-validate.yml -e use_anta=true -e save_catalog=true
Checklist
User Checklist
Repository Checklist