Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Support activity polling-interval for router multicast. #3893

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Feat(eos_cli_config_gen): Support activity polling-interval for router multicast. #3893

merged 1 commit into from
Apr 29, 2024

Conversation

Shivani-gslab
Copy link
Contributor

@Shivani-gslab Shivani-gslab commented Apr 23, 2024 •
edited
Loading

Change Summary

Add support for activity polling-interval in router multicast ipv4/ipv6.

Related Issue(s)

Fixes #3879

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Insert a new key in router_multicast data-model for IPv4 and IPv6 -

router_multicast:
      ipv4:
        # MFIB entry activity polling interval.
        activity_polling_interval: <int; 1-60>

      ipv6:
        # MFIB entry activity polling interval.
        activity_polling_interval: <int; 1-60>

How to test

Added test in molecule scenario and check in EOS CLI.

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@Shivani-gslab Shivani-gslab self-assigned this Apr 23, 2024
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Apr 23, 2024
@sugetha24
Copy link
Contributor

LGTM. Will approve once it's out of drafts!

@Shivani-gslab Shivani-gslab marked this pull request as ready for review April 24, 2024 05:56
@Shivani-gslab Shivani-gslab requested review from a team as code owners April 24, 2024 05:56
MaheshGSLAB
MaheshGSLAB approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@MaheshGSLAB MaheshGSLAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested on lab

@MaheshGSLAB MaheshGSLAB requested a review from a team April 24, 2024 13:13
@ClausHolbechArista ClausHolbechArista merged commit b7e1d36 into aristanetworks:devel Apr 29, 2024
41 checks passed
@kornoa
Copy link
Contributor

kornoa commented Apr 30, 2024

Thank you for implementing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sugetha24 sugetha24 sugetha24 approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@MaheshGSLAB MaheshGSLAB MaheshGSLAB approved these changes

Assignees

@Shivani-gslab Shivani-gslab

Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat(eos_cli_config_gen): Support activity polling-interval for multicast
5 participants
@Shivani-gslab @sugetha24 @kornoa @ClausHolbechArista @MaheshGSLAB