Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: AVD with Ansible Automation Platform Guide #3910

Merged
merged 11 commits into from
Jul 16, 2024

Conversation

JulioPDX
Copy link
Contributor

Change Summary

This getting started guide will walk AVD users through getting up and running with AVD and AAP.

Proposed changes

Please see change summary

How to test

View docs generated with PR

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@JulioPDX JulioPDX requested review from a team as code owners April 26, 2024 00:33
@JulioPDX JulioPDX self-assigned this Apr 26, 2024
@github-actions github-actions bot added the type: documentation Improvements or additions to documentation label Apr 26, 2024
mkdocs.yml Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented May 31, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@danieltudares danieltudares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job Julio!

@JulioPDX
Copy link
Contributor Author

JulioPDX commented Jun 4, 2024

Going to set overwrite on the variables as well to make the source of truth rule all the things.

@JulioPDX
Copy link
Contributor Author

JulioPDX commented Jun 4, 2024

Going to set overwrite on the variables as well to make the source of truth rule all the things.

Disregard, the way we set overwrite on inventory sync, even if folks added a custom var to host or groups, those would be removed when the inventory is updated. Only difference is if someone supplies a job specific variable.

@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Jun 7, 2024
Copy link
Contributor

@ankudinov ankudinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JulioPDX while I requested some changes, I don't think that is critical and overall it's a great guide that has to be published as soon as possible. Ping me any time for 2nd LGTM if you prefer not to fix some comments (like testing with the recent AVD version).

@gmuloc gmuloc added this to the v4.10.0 milestone Jul 5, 2024
@carlbuchmann carlbuchmann dismissed ankudinov’s stale review July 16, 2024 19:19

requested changes have been addressed

Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job on this guide!

@carlbuchmann carlbuchmann merged commit d83d3db into aristanetworks:devel Jul 16, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Doc type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants