Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc: Update CSS to bring code to 100% size #3917

Merged
merged 1 commit into from
May 1, 2024
Merged

Doc: Update CSS to bring code to 100% size #3917

merged 1 commit into from
May 1, 2024

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Update CSS to bring code to 100% size

Proposed changes

  • Remove unused "ivory" CSS
  • Remove CSS override for code blocks to be 80% size.

How to test

Before After
image image
image image

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ClausHolbechArista ClausHolbechArista requested review from a team as code owners April 29, 2024 06:29
@github-actions github-actions bot added the type: documentation Improvements or additions to documentation label Apr 29, 2024
carlbuchmann
carlbuchmann approved these changes May 1, 2024
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, docs look much better!

@JulioPDX
Copy link
Contributor

JulioPDX commented May 1, 2024

I like it! LGTM

JulioPDX
JulioPDX approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@JulioPDX JulioPDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JulioPDX JulioPDX merged commit 6c0ba00 into aristanetworks:devel May 1, 2024
37 checks passed
@JulioPDX
Copy link
Contributor

JulioPDX commented May 1, 2024

In all fairness I believe it brings it to .85em after the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlbuchmann carlbuchmann carlbuchmann approved these changes

@JulioPDX JulioPDX JulioPDX approved these changes

Assignees

@ClausHolbechArista ClausHolbechArista

Labels
rn: Doc type: documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ClausHolbechArista @JulioPDX @carlbuchmann