Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(eos_designs): Make WAN RRs route-reflector clients of each other #3921

Merged

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Apr 29, 2024

Change Summary

This was missed during initial implementation. Confirmed with engineering.

Related Issue(s)

Issue from field

Component(s) name

arista.avd.eos_designs

Proposed changes

Automatically inject neighbor WAN-RR-OVERLAY-PEERS route-reflector-client for the peer group

How to test

molecule shows the fix working

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners April 29, 2024 15:58
@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR role: eos_designs issue related to eos_designs role labels Apr 29, 2024
@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Apr 29, 2024
@gmuloc gmuloc requested a review from a team April 29, 2024 21:57
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tested with WAN-Testing lab topology

@carlbuchmann carlbuchmann merged commit ab95223 into aristanetworks:devel May 1, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EPIC - AVD AutoVPN/WAN one approval This PR has one approval and is only missing one more. rn: Fix(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants