Refactor(cv_deploy): Optimize creation of configlet containers #3950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClausHolbechArista
force-pushed
the
refactor/cv_deploy/optimize-container-creation
branch
from
e13e7b8
to
4cb28a6
Compare
| LOGGER.info("deploy_configs_to_cv: %s existing device containers under AVD root container.", len(existing_device_containers)) | ||
| # Create dict keyed by container id with value of tuple containing key container parameters. Used later to detect changes. | ||
| existing_device_containers_by_id = { | ||
| cv_container.key.configlet_assignment_id: (cv_container.display_name, cv_container.description, cv_container.query, cv_container.configlet_ids) |
There was a problem hiding this comment.
Please add a suggestion with the fix, or just commit the fix directly here.
ansible_collections/arista/avd/plugins/plugin_utils/cv_client/workflows/deploy_configs_to_cv.py
Outdated
Show resolved
Hide resolved
|
alexeygorbunov
approved these changes
Jun 3, 2024
ClausHolbechArista
added
the
one approval
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…workflows/deploy_configs_to_cv.py Co-authored-by: Alexey Gorbunov <[email protected]>
for more information, see https://pre-commit.ci
carlbuchmann
force-pushed
the
refactor/cv_deploy/optimize-container-creation
branch
from
4ffeb78
to
0ed1ec6
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
ClausHolbechArista
force-pushed
the
refactor/cv_deploy/optimize-container-creation
branch
from
b45841e
to
0ed1ec6
Compare
carlbuchmann
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Optimize creation of configlet containers, but only creating/updating missing containers.
Component(s) name
arista.avd.cv_deployProposed changes
How to test
Checklist
User Checklist
Repository Checklist