-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Support for MSS Clamping on ethernet interfaces. #4018
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4018
# Activate the virtual environment
source test-avd-pr-4018/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@interface_tcp_mss#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,interface_tcp_mss --force
# Optional: Install AVD examples
cd test-avd-pr-4018
ansible-playbook arista.avd.install_examples |
...llections/arista/avd/roles/eos_cli_config_gen/templates/documentation/ethernet-interfaces.j2
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Request changes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
...llections/arista/avd/roles/eos_cli_config_gen/templates/documentation/ethernet-interfaces.j2
Outdated
Show resolved
Hide resolved
several changes since reviewed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked the latest changes.
LGTM :)
Change Summary
Support for MSS Clamping on ethernet interfaces.
Related Issue(s)
Fixes #3919
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
Updated
ethernet_interfaces
schema to addtcp_mss_ceiling
:How to test
Molecule tests are added. Test the config in EOS CLI.
Checklist
PR Checklist
Repository Checklist