Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Support for MSS Clamping on ethernet interfaces. #4018

Merged
merged 2 commits into from
May 22, 2024

Conversation

Shivani-gslab
Copy link
Contributor

@Shivani-gslab Shivani-gslab commented May 20, 2024

Change Summary

Support for MSS Clamping on ethernet interfaces.

Related Issue(s)

Fixes #3919

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Updated ethernet_interfaces schema to add tcp_mss_ceiling :

tcp_mss_ceiling:
     ipv4_segment_size: <int; 64-65475>
     ipv6_segment_size: <int; 64-65475>

     # Enforce on packets forwarded to the network.
     egress: <bool>

     # Enforce on packets arriving from the network.
     ingress: <bool>

How to test

Molecule tests are added. Test the config in EOS CLI.

Checklist

PR Checklist

  • Check the command ordering on EOS CLI.
  • Implement the documentation template (if required).

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4018
# Activate the virtual environment
source test-avd-pr-4018/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@interface_tcp_mss#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,interface_tcp_mss --force
# Optional: Install AVD examples
cd test-avd-pr-4018
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels May 20, 2024
Copy link
Contributor

@Vibhu-gslab Vibhu-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request changes!

Vibhu-gslab
Vibhu-gslab previously approved these changes May 21, 2024
Copy link
Contributor

@Vibhu-gslab Vibhu-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review May 21, 2024 07:13
@Vibhu-gslab Vibhu-gslab requested review from a team as code owners May 21, 2024 07:13
@ClausHolbechArista ClausHolbechArista dismissed Vibhu-gslab’s stale review May 21, 2024 11:19

several changes since reviewed.

@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label May 21, 2024
@ClausHolbechArista ClausHolbechArista requested a review from a team May 21, 2024 12:50
Copy link
Contributor

@Vibhu-gslab Vibhu-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the latest changes.
LGTM :)

@gmuloc gmuloc merged commit d30a4b5 into aristanetworks:devel May 22, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat(eos_cli_config_gen): Support for MSS Clamping on ethernet interfaces
4 participants