-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_designs): Add support for 'uplink_mtu' under node config #4040
Feat(eos_designs): Add support for 'uplink_mtu' under node config #4040
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4040
# Activate the virtual environment
source test-avd-pr-4040/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@uplinkmtu#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,uplinkmtu --force
# Optional: Install AVD examples
cd test-avd-pr-4040
ansible-playbook arista.avd.install_examples |
..._collections/arista/avd/roles/eos_designs/schemas/schema_fragments/defs_node_type.schema.yml
Outdated
Show resolved
Hide resolved
7a6510a
to
91fc6fd
Compare
91fc6fd
to
ca3279d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, but overall looks good to me.
..._collections/arista/avd/roles/eos_designs/schemas/schema_fragments/defs_node_type.schema.yml
Outdated
Show resolved
Hide resolved
..._collections/arista/avd/roles/eos_designs/schemas/schema_fragments/defs_node_type.schema.yml
Outdated
Show resolved
Hide resolved
..._collections/arista/avd/roles/eos_designs/schemas/schema_fragments/defs_node_type.schema.yml
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Change Summary
It is currently not possible to set the uplink mtu to dedicated leaf node or node group.
This change will add
uplink_mtu
for node_group and node settings.Related Issue(s)
Fixes #3985
Component(s) name
arista.avd.eos_designs
Proposed changes
Add option
uplink_mtu
under node_config.How to test
Add key
uplink_mtu
under node_groups or node settings. Verify configuration.Checklist
User Checklist
Repository Checklist