Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_designs): Add support for 'uplink_mtu' under node config #4040

Merged

Conversation

laxmikantchintakindi
Copy link
Contributor

@laxmikantchintakindi laxmikantchintakindi commented May 27, 2024

Change Summary

It is currently not possible to set the uplink mtu to dedicated leaf node or node group.
This change will add uplink_mtu for node_group and node settings.

Related Issue(s)

Fixes #3985

Component(s) name

arista.avd.eos_designs

Proposed changes

Add option uplink_mtu under node_config.

# Define variables related to all nodes part of this group.
node_groups:
    # Override the default `uplink_mtu` set at the `node_type_key` level.
    uplink_mtu: <str>

    # Define variables per node.
    nodes:
        # The Node Name is used as "hostname".
      - name: <str; required; unique>

        # Override the default `uplink_mtu` set at the `node_type_key` level.
        uplink_mtu: <str>

How to test

Add key uplink_mtu under node_groups or node settings. Verify configuration.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4040
# Activate the virtual environment
source test-avd-pr-4040/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@uplinkmtu#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,uplinkmtu --force
# Optional: Install AVD examples
cd test-avd-pr-4040
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels May 27, 2024
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, but overall looks good to me.

Copy link

sonarcloud bot commented May 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@ClausHolbechArista ClausHolbechArista requested a review from a team May 29, 2024 07:07
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label May 29, 2024
@laxmikantchintakindi laxmikantchintakindi changed the title Feat(eos_designs): Add option 'uplink_mtu' under node config. Feat(eos_designs): Add support for 'uplink_mtu' under node config May 29, 2024
Copy link
Contributor

@Shivani-gslab Shivani-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit fca5ac0 into aristanetworks:devel May 29, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat(eos_designs): add option uplink_mtu under the node config
3 participants