Fix(eos_designs): core_interfaces generates invalid config if ASN is not defined for the p2p_links/p2p_links_profiles

[Shivani-gslab]

Change Summary

Current code is converting the bgp_as value to string, where None value is also getting converted to type string, which is revoking the check for None value to raise the AristaAvdMissingVariableError even if core_interfaces.p2p_links.[].as is not defined.

Fixing the code and tests for the same.

Related Issue(s)

Fixes #3596

Component(s) name

arista.avd.eos_designs

Proposed changes

Fixing the type conversion in ansible_collections/arista/avd/roles/eos_designs/python_modules/core_interfaces_and_l3_edge/utils.py

How to test

Test by not defining core_interfaces.p2p_links.[].as in input and run the eos_designs role. AristaAvdMissingVariableError is expected.

Check the test added in eos_designs_negative_unit_tests molecule scenario.

Checklist

Repository Checklist

• My code has been rebased from devel before I start
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation and documentation have been updated accordingly.
• I have updated molecule CI testing accordingly. (check the box if not applicable)

[github-actions]

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4046
# Activate the virtual environment
source test-avd-pr-4046/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@core_interfaces_p2p_links_as#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,core_interfaces_p2p_links_as --force
# Optional: Install AVD examples
cd test-avd-pr-4046
ansible-playbook arista.avd.install_examples

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud