-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor(plugins): Move jinja filter code for arista.avd.default
to PyAVD
#4047
Merged
ClausHolbechArista
merged 29 commits into
aristanetworks:devel
from
ClausHolbechArista:refactor/move-jinja-filter-code-to-pyavd/default
May 31, 2024
Merged
Refactor(plugins): Move jinja filter code for arista.avd.default
to PyAVD
#4047
ClausHolbechArista
merged 29 commits into
aristanetworks:devel
from
ClausHolbechArista:refactor/move-jinja-filter-code-to-pyavd/default
May 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4047
# Activate the virtual environment
source test-avd-pr-4047/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@refactor/move-jinja-filter-code-to-pyavd/default#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,refactor/move-jinja-filter-code-to-pyavd/default --force
# Optional: Install AVD examples
cd test-avd-pr-4047
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
type: Python filters
type: code quality
CI and development toolset
role: eos_validate_state
labels
May 28, 2024
Vibhu-gslab
force-pushed
the
refactor/move-jinja-filter-code-to-pyavd/default
branch
from
May 30, 2024 10:54
5abd758
to
1918963
Compare
ClausHolbechArista
force-pushed
the
refactor/move-jinja-filter-code-to-pyavd/default
branch
from
May 31, 2024 13:02
cba5fc2
to
e799d16
Compare
Quality Gate passedIssues Measures |
carlbuchmann
approved these changes
May 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
rn: Refactor(plugins)
role: eos_validate_state
type: code quality
CI and development toolset
type: Python filters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Move jinja filter code for
arista.avd.default
to PyAVDComponent(s) name
Filter
arista.avd.default
Proposed changes
arista.avd.default
code to PyAVD and optimize the implementation.How to test
CI should catch things.
Checklist
User Checklist
Repository Checklist