Fix(eos_validate_state): Update error message when a device does not have httpapi _sub_plugin #4049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4049
# Activate the virtual environment
source test-avd-pr-4049/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@issue-3882#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,issue-3882 --force
# Optional: Install AVD examples
cd test-avd-pr-4049
ansible-playbook arista.avd.install_examples |
MaheshGSLAB
changed the title
Vibhu-gslab
reviewed
May 29, 2024
...e_collections/arista/avd/plugins/plugin_utils/eos_validate_state_utils/ansible_eos_device.py
Outdated
Show resolved
Hide resolved
Vibhu-gslab
changed the title
| else: | ||
| raise AristaAvdError(message=f"The provided Ansible connection does not use EOS HttpApi plugin: {plugin_name}") | ||
| except AttributeError as err: | ||
| raise AristaAvdError(message="AVD could not determine ansible connection. Please configure ansible_connection as `httpapi` for this host.") from err |
There was a problem hiding this comment.
Suggested change
| raise AristaAvdError(message="AVD could not determine ansible connection. Please configure ansible_connection as `httpapi` for this host.") from err | |
| raise AristaAvdError(message="AVD could not determine the Ansible connection plugin used. Please ensure that the 'ansible_network_os' and 'ansible_connection' variables are set to 'eos' and 'httpapi' respectively for this host.") from err |
There was a problem hiding this comment.
Fixed.
If ansible_network_os is not defined and ansible_connection defined as httpapi then we face below error
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: AttributeError: 'Connection' object has no attribute 'nonetype'
fatal: [leaf2-dc1]: FAILED! => {"msg": "Unexpected failure during module execution: 'Connection' object has no attribute 'nonetype'", "stdout": ""}
and this is from netcommon collection
File "/home/maheshkumar/Projecct/ansible-avd/ansible_collections/ansible/netcommon/plugins/plugin_utils/connection_base.py", line 50, in __getattr__
raise AttributeError(
AttributeError: 'Connection' object has no attribute 'nonetype'
fatal: [leaf2-dc1]: FAILED! => {
"msg": "Unexpected failure during module execution: 'Connection' object has no attribute 'nonetype'",
"stdout": ""
}
cc: @gmuloc
There was a problem hiding this comment.
Lets make all this nice maybe outside of the try except
Co-authored-by: Carl Baillargeon <[email protected]>
for more information, see https://pre-commit.ci
gmuloc
approved these changes
Jun 5, 2024
gmuloc
added
the
one approval
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Better error message needed when a device does not have httpapi _sub_plugin
Related Issue(s)
Fixes #3882
Component(s) name
arista.avd.eos_validate_stateProposed changes
Added the If condition to check _sub_plugin is there or not.
How to test
To reproduce issue we have to comment out ansible_connection vars.
Checklist
User Checklist
Repository Checklist