Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump(pyavd): Add support for Python 3.9 in PyAVD #4051

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Add support for Python 3.9 in PyAVD

How to test

  • Adding test coverage for python 3.9 in tox.
  • Excluding a few incompatible tests for python 3.9.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ClausHolbechArista ClausHolbechArista requested review from a team as code owners May 29, 2024 13:34
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4051
# Activate the virtual environment
source test-avd-pr-4051/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@bump/pyavd/support-python3.9#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,bump/pyavd/support-python3.9 --force
# Optional: Install AVD examples
cd test-avd-pr-4051
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added the type: code quality CI and development toolset label May 29, 2024
@Vibhu-gslab Vibhu-gslab force-pushed the bump/pyavd/support-python3.9 branch from c2fdefc to 300625c Compare May 30, 2024 11:05
Copy link

sonarcloud bot commented May 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ClausHolbechArista
Copy link
Contributor Author

Tested offline by @philippebureau.

@ClausHolbechArista ClausHolbechArista merged commit 34ceb0f into aristanetworks:devel May 31, 2024
46 checks passed
@carlbuchmann
Copy link
Member

carlbuchmann commented May 31, 2024

LGTM!

Tested with Python 3.9.18, no diffs in configs between Python 3.11 and PyAVD 4.8.0

 dc-fabrics git:(main) ✗ python --version
Python 3.9.18
➜  dc-fabrics git:(main) ✗ pip freeze
attrs==23.2.0
colorama==0.4.6
deepmerge==1.1.1
importlib-metadata==4.13.0
Jinja2==3.1.4
jsonschema==4.22.0
jsonschema-specifications==2023.12.1
MarkupSafe==2.1.5
mypy-extensions==1.0.0
nornir==3.4.1
nornir-ansible==2023.12.28
nornir-utils==0.2.0
pyavd @ file:///home/carlbuchmann/git_projects/studios-builder-project/test-fabric/dc-fabrics/pyavd-4.8.0-py3-none-any.whl
referencing==0.35.1
rpds-py==0.18.1
ruamel.yaml==0.18.6
ruamel.yaml.clib==0.2.8
zipp==3.19.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Bump(pyavd) type: code quality CI and development toolset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants