-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(eos_cli_config_gen): Fix the templates for event-handlers #4055
Fix(eos_cli_config_gen): Fix the templates for event-handlers #4055
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4055
# Activate the virtual environment
source test-avd-pr-4055/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@event-handlers-trigger#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,event-handlers-trigger --force
# Optional: Install AVD examples
cd test-avd-pr-4055
ansible-playbook arista.avd.install_examples |
b365cf0
to
bde9547
Compare
...le_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/event-handlers.j2
Show resolved
Hide resolved
...le_collections/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/event-handlers.yml
Show resolved
Hide resolved
4445b0e
to
7f0bcf0
Compare
c2c0704
to
e54ca54
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment otherwise LGTM!
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/event-handlers.j2
Show resolved
Hide resolved
dabb3aa
to
b4ea0e0
Compare
...e_collections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/event-handlers.md
Show resolved
Hide resolved
...le_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/event-handlers.j2
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/event-handlers.j2
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/event-handlers.j2
Outdated
Show resolved
Hide resolved
9afcbe8
to
fe0afb4
Compare
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/event-handlers.j2
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/event-handlers.j2
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm and works in my env +1
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/event-handlers.j2
Outdated
Show resolved
Hide resolved
2624a1e
to
5a622f4
Compare
for more information, see https://pre-commit.ci
Co-authored-by: Vibhu-gslab <[email protected]>
5a622f4
to
f7e6387
Compare
Quality Gate passedIssues Measures |
Change Summary
Current documentation template for
event-handlers
throws error ifpoll_interval
is not defined fortrigger_on_counters
andtrigger_on_logging
Few updates in config template and its test-cases.
Related Issue(s)
Fixes #
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
Changing the logic to add multiple entries in the table for event-handler triggers
How to test
Do not provide
poll_interval
fortrigger_on_counters
andtrigger_on_logging
input and give other options.Run the playbook for eos_cli_config_gen, you should not see any error and the documentation output should be proper.
Checklist
Repository Checklist